Merge pull request #729 from howjmay/go-ver

chore: Sync all the go version

Author: howjmay

.github/workflows/build-test.yml

@@ -14,7 +14,7 @@ jobs:
       - name: Set up Go 1.x
         uses: actions/setup-go@v5
         with:
-          go-version: "1.24.0"
+          go-version: "1.24"
         id: go
 
       - name: Check out code into the Go module directory
@@ -38,7 +38,7 @@ jobs:
       - name: Set up Go 1.x
         uses: actions/setup-go@v5
         with:
-          go-version: "1.24.0"
+          go-version: "1.24"
         id: go
 
       - name: Check out code into the Go module directory
@@ -59,23 +59,23 @@ jobs:
     steps:
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.24.0"
+          go-version: "1.24"
         id: go
 
       - name: Check out code into the Go module directory
         uses: actions/checkout@v4
 
       - name: Run global scope golangci-lint
-        uses: golangci/golangci-lint-action@v7
+        uses: golangci/golangci-lint-action@v8
         with:
-          version: v2.0
+          version: v2.5
           args: --timeout 15m0s
           skip-cache: true
 
       - name: Run golangci-lint on wasp-cli
-        uses: golangci/golangci-lint-action@v7
+        uses: golangci/golangci-lint-action@v8
         with:
           working-directory: tools/wasp-cli
-          version: v2.0
+          version: v2.5
           args: --timeout 15m0s
           skip-cache: true

.github/workflows/go-mod-tidy.yml

@@ -14,7 +14,7 @@ jobs:
       - name: Set up Go 1.x
         uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.24"
         id: go
 
       - name: Generate token # generate a token to trigger the rest of the CI tasks... https://github.com/tibdex/github-app-token

.github/workflows/iotago-test.yml

@@ -14,10 +14,9 @@ jobs:
     - name: Set up Go 1.x
       uses: actions/setup-go@v5
       with:
-        go-version: '1.21'
+        go-version: '1.24'
 
     - name: Test
       run: |
         cd clients/iota-go
         go test -v ./...
-

go.mod

@@ -1,8 +1,8 @@
 module github.com/iotaledger/wasp/v2
 
-go 1.23.8
+go 1.24
 
-toolchain go1.24.3
+toolchain go1.24.7
 
 replace (
 	github.com/ethereum/go-ethereum => github.com/iotaledger/go-ethereum v1.16.2-wasp

packages/evm/evmutil/events.go

@@ -11,7 +11,7 @@ import (
 
 func AddressToIndexedTopic(addr common.Address) (ret common.Hash) {
 	copy(ret[len(ret)-len(addr):], addr[:])
-	return
+	return ret
 }
 
 func PackUint256(uint256 *big.Int) []byte {

packages/evm/jsonrpc/tracer_internal.go

@@ -44,10 +44,9 @@ func memoryCopy(m []byte, offset, size int64) (cpy []byte) {
 		cpy = make([]byte, size)
 		copy(cpy, m[offset:offset+size])
 
-		return
+		return cpy
 	}
-
-	return
+	return nil
 }
 
 // MemoryPtr returns a pointer to a slice of memory.

packages/evm/jsonrpc/types.go

@@ -242,7 +242,7 @@ func (c *RPCCallArgs) parse() (ret ethereum.CallMsg) {
 	if c.Input != nil {
 		ret.Data = *c.Input
 	}
-	return
+	return ret
 }
 
 // SendTxArgs represents the arguments to submit a new transaction into the transaction pool.

packages/evm/solidity/abi.go

@@ -18,7 +18,7 @@ func StorageSlot(n uint8) common.Hash {
 // StorageEncodeUint8 encodes an uint8 according to the storage spec.
 func StorageEncodeUint8(n uint8) (ret common.Hash) {
 	ret[len(ret)-1] = n
-	return
+	return ret
 }
 
 // StorageEncodeShortString encodes a short string according to the storage spec.
@@ -37,7 +37,7 @@ func StorageEncodeString(slotNumber uint8, s string) (ret map[common.Hash]common
 	ret = make(map[common.Hash]common.Hash)
 	if len(s) <= 31 {
 		ret[mainSlot] = StorageEncodeShortString(s)
-		return
+		return ret
 	}
 
 	ret[mainSlot] = common.BigToHash(big.NewInt(int64(len(s)*2) + 1))
@@ -59,7 +59,7 @@ func StorageEncodeString(slotNumber uint8, s string) (ret map[common.Hash]common
 		}
 		i++
 	}
-	return
+	return ret
 }
 
 // StorageEncodeBytes encodes a byte array according to the storage spec.
@@ -78,5 +78,5 @@ func StorageEncodeBytes32(b []byte) (ret common.Hash) {
 		panic("expected len(b) == 32")
 	}
 	copy(ret[:], b)
-	return
+	return ret
 }

packages/hashing/hash.go

@@ -91,7 +91,7 @@ func HashDataBlake2b(data ...[]byte) (ret HashValue) {
 		}
 	}
 	copy(ret[:], h.Sum(nil))
-	return
+	return ret
 }
 
 func hashBlake2b() hash.Hash {
@@ -114,7 +114,7 @@ func HashKeccak(data ...[]byte) (ret HashValue) {
 		}
 	}
 	copy(ret[:], h.Sum(nil))
-	return
+	return ret
 }
 
 func hashKeccak() hash.Hash {
@@ -134,7 +134,7 @@ func HashSha3(data ...[]byte) (ret HashValue) {
 		}
 	}
 	copy(ret[:], h.Sum(nil))
-	return
+	return ret
 }
 
 func hashSha3() hash.Hash {

packages/isc/vmerror.go

@@ -90,7 +90,8 @@ func (e *VMErrorTemplate) Create(params ...VMErrorParam) *VMError {
 // VMErrorTemplate by mistake, so that we don't crash the VM because of that.
 func (e *VMErrorTemplate) Error() string {
 	// calling Sprintf so that it marks missing parameters as errors
-	return fmt.Sprintf(e.messageFormat)
+	var noargs []any
+	return fmt.Sprintf(e.messageFormat, noargs...)
 }
 
 func (e *VMErrorTemplate) MessageFormat() string {