fix: return error for unknown method in rolldpos BuildReadStateRequest (#4789)

envestcc · Copilot · web-flow · commit 9eb3aaa58705 · 2026-03-12T11:09:15.000+08:00
BuildReadStateRequest returned nil, nil for unknown methods, silently
hiding the error from callers. Now returns an error with the unknown
method name for proper error handling.

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/action/protocol/rolldpos/ethabi/abi.go b/action/protocol/rolldpos/ethabi/abi.go
@@ -93,8 +93,8 @@ func BuildReadStateRequest(data []byte) (protocol.StateContext, error) {
 	case subEpochNumberMethod.RawName:
 		return newUint64StateContext(data[4:], method, "SubEpochNumber")
 	default:
+		return nil, errors.Errorf("unknown method %s", method.RawName)
 	}
-	return nil, nil
 }
 
 // Uint64StateContext handles methods that return a uint64 value

Original file line number	Diff line number	Diff line change
`@@ -93,8 +93,8 @@ func BuildReadStateRequest(data []byte) (protocol.StateContext, error) {`
`93`	`93`	`case subEpochNumberMethod.RawName:`
`94`	`94`	`return newUint64StateContext(data[4:], method, "SubEpochNumber")`
`95`	`95`	`default:`
	`96`	`+ return nil, errors.Errorf("unknown method %s", method.RawName)`
`96`	`97`	`}`
`97`		`- return nil, nil`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`// Uint64StateContext handles methods that return a uint64 value`