Commit f0a399b
fix: return error instead of nil in ethabi EncodeToEth methods (#4784)
Six ethabi files incorrectly returned nil instead of err when
Outputs.Pack() failed, silently swallowing the error. This fix
ensures the actual error is propagated to callers.
Files fixed:
- action/protocol/rewarding/ethabi/availablebalance.go
- action/protocol/rewarding/ethabi/totalbalance.go
- action/protocol/rewarding/ethabi/unclaimedbalance.go
- action/protocol/staking/ethabi/common/candidatebyname.go
- action/protocol/staking/ethabi/common/stake_totalstakingamount.go
- action/protocol/staking/ethabi/common/types.go
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent a70ad6b commit f0a399b
File tree
6 files changed
+6
-6
lines changed- action/protocol
- rewarding/ethabi
- staking/ethabi/common
6 files changed
+6
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| |||
0 commit comments