Skip to content

Commit a88d45d

Browse files
committed
Fix provider dropdown z-index issues
1 parent d9af2ac commit a88d45d

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "claude-dev",
33
"displayName": "Cline",
44
"description": "Autonomous coding agent right in your IDE, capable of creating/editing files, running commands, using the browser, and more with your permission every step of the way.",
5-
"version": "3.2.3",
5+
"version": "3.2.4",
66
"icon": "assets/icons/icon.png",
77
"galleryBanner": {
88
"color": "#617A91",

webview-ui/src/components/settings/ApiOptions.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ interface ApiOptionsProps {
5050
// This is necessary to ensure dropdown opens downward, important for when this is used in popup
5151
const DROPDOWN_Z_INDEX = 1001 // Higher than the OpenRouterModelPicker's and ModelSelectorTooltip's z-index
5252

53-
const DropdownContainer = styled.div`
53+
const DropdownContainer = styled.div<{ zIndex?: number }>`
5454
position: relative;
55-
z-index: ${DROPDOWN_Z_INDEX};
55+
z-index: ${(props) => props.zIndex || DROPDOWN_Z_INDEX};
5656
5757
// Force dropdowns to open downward
5858
& vscode-dropdown::part(listbox) {
@@ -406,7 +406,7 @@ const ApiOptions = ({ showModelOptions, apiErrorMessage, modelIdErrorMessage, is
406406
placeholder="Enter Session Token...">
407407
<span style={{ fontWeight: 500 }}>AWS Session Token</span>
408408
</VSCodeTextField>
409-
<div className="dropdown-container">
409+
<DropdownContainer zIndex={DROPDOWN_Z_INDEX - 1} className="dropdown-container">
410410
<label htmlFor="aws-region-dropdown">
411411
<span style={{ fontWeight: 500 }}>AWS Region</span>
412412
</label>
@@ -442,7 +442,7 @@ const ApiOptions = ({ showModelOptions, apiErrorMessage, modelIdErrorMessage, is
442442
<VSCodeOption value="us-gov-west-1">us-gov-west-1</VSCodeOption>
443443
{/* <VSCodeOption value="us-gov-east-1">us-gov-east-1</VSCodeOption> */}
444444
</VSCodeDropdown>
445-
</div>
445+
</DropdownContainer>
446446
<VSCodeCheckbox
447447
checked={apiConfiguration?.awsUseCrossRegionInference || false}
448448
onChange={(e: any) => {
@@ -481,7 +481,7 @@ const ApiOptions = ({ showModelOptions, apiErrorMessage, modelIdErrorMessage, is
481481
placeholder="Enter Project ID...">
482482
<span style={{ fontWeight: 500 }}>Google Cloud Project ID</span>
483483
</VSCodeTextField>
484-
<div className="dropdown-container">
484+
<DropdownContainer zIndex={DROPDOWN_Z_INDEX - 2} className="dropdown-container">
485485
<label htmlFor="vertex-region-dropdown">
486486
<span style={{ fontWeight: 500 }}>Google Cloud Region</span>
487487
</label>
@@ -497,7 +497,7 @@ const ApiOptions = ({ showModelOptions, apiErrorMessage, modelIdErrorMessage, is
497497
<VSCodeOption value="europe-west4">europe-west4</VSCodeOption>
498498
<VSCodeOption value="asia-southeast1">asia-southeast1</VSCodeOption>
499499
</VSCodeDropdown>
500-
</div>
500+
</DropdownContainer>
501501
<p
502502
style={{
503503
fontSize: "12px",
@@ -613,7 +613,7 @@ const ApiOptions = ({ showModelOptions, apiErrorMessage, modelIdErrorMessage, is
613613

614614
{selectedProvider === "vscode-lm" && (
615615
<div>
616-
<div className="dropdown-container">
616+
<DropdownContainer zIndex={DROPDOWN_Z_INDEX - 2} className="dropdown-container">
617617
<label htmlFor="vscode-lm-model">
618618
<span style={{ fontWeight: 500 }}>Language Model</span>
619619
</label>
@@ -669,7 +669,7 @@ const ApiOptions = ({ showModelOptions, apiErrorMessage, modelIdErrorMessage, is
669669
}}>
670670
Note: This is a very experimental integration and may not work as expected.
671671
</p>
672-
</div>
672+
</DropdownContainer>
673673
</div>
674674
)}
675675

@@ -818,7 +818,7 @@ const ApiOptions = ({ showModelOptions, apiErrorMessage, modelIdErrorMessage, is
818818
selectedProvider !== "vscode-lm" &&
819819
showModelOptions && (
820820
<>
821-
<div className="dropdown-container">
821+
<DropdownContainer zIndex={DROPDOWN_Z_INDEX - 2} className="dropdown-container">
822822
<label htmlFor="model-id">
823823
<span style={{ fontWeight: 500 }}>Model</span>
824824
</label>
@@ -829,7 +829,7 @@ const ApiOptions = ({ showModelOptions, apiErrorMessage, modelIdErrorMessage, is
829829
{selectedProvider === "openai-native" && createDropdown(openAiNativeModels)}
830830
{selectedProvider === "deepseek" && createDropdown(deepSeekModels)}
831831
{selectedProvider === "mistral" && createDropdown(mistralModels)}
832-
</div>
832+
</DropdownContainer>
833833

834834
<ModelInfoView
835835
selectedModelId={selectedModelId}

0 commit comments

Comments
 (0)