Remove cppcoreguidelines-pro-type-member-init linting

Author: zfergus

.clang-tidy

@@ -12,7 +12,6 @@ Checks: >
 
   # Specific high-value checks (even if not in a group above)
   google-runtime-int,
-  cppcoreguidelines-pro-type-member-init,
 
   # Exclusions/Suppressions (Checks often considered too aggressive or subjective)
   -bugprone-throwing-static-initialization,

src/ipc/broad_phase/aabb.cpp

@@ -9,7 +9,6 @@
 
 namespace ipc {
 
-// NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
 AABB::AABB(Eigen::ConstRef<ArrayMax3d> _min, Eigen::ConstRef<ArrayMax3d> _max)
     : min(Eigen::Array3d::Zero())
     , max(Eigen::Array3d::Zero())

src/ipc/broad_phase/aabb.hpp

@@ -9,21 +9,17 @@
 namespace ipc {
 
 /// @brief Axis aligned bounding-box of some type
-// NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
 class alignas(64) AABB {
 public:
-    // NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
     AABB() = default;
 
     AABB(Eigen::ConstRef<ArrayMax3d> min, Eigen::ConstRef<ArrayMax3d> max);
 
-    // NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
     AABB(const AABB& aabb1, const AABB& aabb2)
         : AABB(aabb1.min.min(aabb2.min), aabb1.max.max(aabb2.max))
     {
     }
 
-    // NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
     AABB(const AABB& aabb1, const AABB& aabb2, const AABB& aabb3)
         : AABB(
               aabb1.min.min(aabb2.min).min(aabb3.min),

src/ipc/broad_phase/lbvh.hpp

@@ -8,12 +8,10 @@
 namespace ipc {
 
 /// @brief Linear Bounding Volume Hierarchy (LBVH) broad phase collision detection.
-// NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
 class LBVH : public BroadPhase {
 public:
     static constexpr index_t INVALID_ID = 0xFFFFFFFF;
 
-    // NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
     struct alignas(32) Node {
         static constexpr int32_t INVALID_POINTER = 0x0; // do not change
 

src/ipc/utils/eigen_ext.hpp

@@ -262,7 +262,7 @@ static const Eigen::IOFormat OBJ_VERTEX_FORMAT = Eigen::IOFormat(
 #if EIGEN_VERSION_AT_LEAST(3, 4, 90)
 namespace Eigen {
 // Move all back to the root namespace for compatibility with older versions
-static const Eigen::internal::all_t all = indexing::all;
+static const Eigen::internal::all_t all = indexing::all; // NOLINT
 } // namespace Eigen
 #endif