Skip to content

Commit 76ebff7

Browse files
committed
Make tone more casual and remove overly structured language
- Remove 'Never look like novice again' tagline - Make README more personal and less structured - Use casual language based on real experience - Remove overly formal descriptions
1 parent 29dea54 commit 76ebff7

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

CHANGELOG.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,5 @@
3939
- Professional email responses
4040
- Cover letter structure
4141

42-
This validator was created after experiencing multiple patch rejections
43-
and learning from maintainer feedback. It embodies the lessons learned
44-
from real kernel development experience.
42+
Built this after getting too many patch rejections for basic mistakes.
43+
Each check is based on real feedback from kernel maintainers.

README.md

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
[![License: GPL v2](https://img.shields.io/badge/License-GPL%20v2-blue.svg)](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html)
44
[![GitHub Issues](https://img.shields.io/github/issues/ipenas-cl/kernel-patch-validator)](https://github.com/ipenas-cl/kernel-patch-validator/issues)
55

6-
Never send a bad patch again! This toolkit helps you validate patches before sending them to Linux kernel mailing lists.
6+
Validate patches before sending them to Linux kernel mailing lists.
77

8-
Born from real experience of patch rejections and maintainer feedback, this validator catches the common mistakes that immediately mark you as a novice contributor.
8+
After getting patches rejected multiple times by maintainers, I built this validator to catch the common mistakes that get patches rejected immediately.
99

1010
## Quick Start
1111

@@ -176,14 +176,11 @@ Found a bug or have a suggestion? Please contribute!
176176

177177
This toolkit is meant to help everyone avoid novice mistakes.
178178

179-
## Inspiration
179+
## Background
180180

181-
This validator was created after experiencing real patch rejections from Linux kernel maintainers including:
182-
- Dan Carpenter's feedback on patch quality
183-
- Greg KH's automated responses about patch format
184-
- Multiple v2, v3, v4+ iterations learning the process
181+
Built this after my patches kept getting rejected for basic formatting issues and style problems. Got tired of the back-and-forth with maintainers like Dan Carpenter and Greg KH over things that should be caught before submitting.
185182

186-
Every check in this validator represents a real mistake that was made and learned from.
183+
Each check here is based on an actual mistake I made and had to fix.
187184

188185
## License
189186

scripts/quick-check.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
# Super quick sanity check - run this ALWAYS before git send-email
2+
# Quick sanity check - run before git send-email
33

44
PATCH="$1"
55

scripts/validate-patch.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
# Kernel Patch Validator - Never look like a novice again!
2+
# Kernel Patch Validator
33
# By Ignacio Peña - July 2024
44

55
set -e

0 commit comments

Comments
 (0)