Fix various shellcheck warnings (#928)

Author: ipetkov

lib/setupHooks/cargoHelperFunctionsHook.sh

@@ -10,11 +10,11 @@ cargo() {
 # Injects `--profile $CARGO_PROFILE` into a particular cargo invocation
 # if the environment variable is set
 cargoWithProfile() {
-  local profileArgs
+  local profileArgs=()
   if [[ "${CARGO_PROFILE}" == "release" ]]; then
-    profileArgs="--release"
-  else
-    profileArgs="${CARGO_PROFILE:+--profile ${CARGO_PROFILE}}"
+    profileArgs+=("--release")
+  elif [[ -n "${CARGO_PROFILE:-}" ]]; then
+    profileArgs+=("--profile" "${CARGO_PROFILE}")
   fi
-  cargo "${@:1:1}" ${profileArgs} "${@:2}"
+  cargo "${@:1:1}" "${profileArgs[@]}" "${@:2}"
 }

lib/setupHooks/configureCargoVendoredDepsHook.sh

@@ -9,12 +9,12 @@ configureCargoVendoredDepsHook() {
   # doing and has its own source replacement going on, it can happily
   # ignore the changes we are trying to make!
   if [[ -f "${vendoredDir}/config.toml" ]]; then
-    echo will append ${cargoConfig} with contents of ${vendoredDir}/config.toml
+    echo "will append ${cargoConfig} with contents of ${vendoredDir}/config.toml"
     cat "${vendoredDir}/config.toml" >>"${cargoConfig}"
     return
   fi
 
-  echo setting source replacement config in ${cargoConfig} using vendored directory ${vendoredDir}
+  echo "setting source replacement config in ${cargoConfig} using vendored directory ${vendoredDir}"
   cat >>"${cargoConfig}" <<EOF
 
 [source.crates-io]

lib/setupHooks/inheritCargoArtifactsHook.sh

@@ -90,7 +90,8 @@ inheritCargoArtifacts() {
          done
        ' \;
 
-      local linkCandidates=$(mktemp linkCandidatesXXXX.txt)
+      local linkCandidates
+      linkCandidates="$(mktemp linkCandidatesXXXX.txt)"
       find "${preparedArtifacts}" \
         '(' -path '*/deps/*.rlib' -or -path '*/deps/*.rmeta' ')' \
         -printf "%P\n" \
@@ -100,14 +101,14 @@ inheritCargoArtifacts() {
       cat "${linkCandidates}" \
         | xargs --no-run-if-empty -n1 dirname \
         | sort -u \
-        | (cd "${cargoTargetDir}"; xargs --no-run-if-empty mkdir -p)
+        | (cd "${cargoTargetDir}" || exit 1; xargs --no-run-if-empty mkdir -p)
 
       # Lastly do the actual symlinking
       cat "${linkCandidates}" \
-        | xargs -P ${NIX_BUILD_CORES} -I '##{}##' ln -s "${preparedArtifacts}/##{}##" "${cargoTargetDir}/##{}##"
+        | xargs -P "${NIX_BUILD_CORES:-0}" -I '##{}##' ln -s "${preparedArtifacts}/##{}##" "${cargoTargetDir}/##{}##"
     fi
   else
-    echo unable to copy cargo artifacts, \"${preparedArtifacts}\" looks invalid
+    echo "unable to copy cargo artifacts, \"${preparedArtifacts}\" looks invalid"
     false
   fi
 }

lib/setupHooks/installCargoArtifactsHook.sh

@@ -35,6 +35,7 @@ compressAndInstallCargoArtifactsDir() {
     )
 
     if [[ -d "${cargoTargetDir}" ]]; then
+      # shellcheck disable=SC2086
       dynTar \
         --sort=name \
         --mtime="@${SOURCE_DATE_EPOCH}" \

lib/setupHooks/installFromCargoBuildLogHook.sh

@@ -3,11 +3,11 @@ function installFromCargoBuildLog() (
   local log=${2:-${cargoBuildLog:?not defined}}
 
   if ! [ -f "${log}" ]; then
-    echo unable to install, cargo build log does not exist at: ${log}
+    echo "unable to install, cargo build log does not exist at: ${log}"
     false
   fi
 
-  echo searching for bins/libs to install from cargo build log at ${log}
+  echo "searching for bins/libs to install from cargo build log at ${log}"
 
   local logs
   logs=$(@jq@ -R 'fromjson?' <"${log}")
@@ -19,7 +19,9 @@ function installFromCargoBuildLog() (
   local select_non_deps_artifact='select(contains("/deps/artifact/") | not)'
 
   # Only install binaries and libraries from the current workspace as a sanity check
-  local members="$(command cargo metadata --format-version 1 | @jq@ -c '.workspace_members')"
+  local members
+  members="$(command cargo metadata --format-version 1 | @jq@ -c '.workspace_members')"
+  # shellcheck disable=SC2016
   local select_non_test_members='select(.reason == "compiler-artifact" and .profile.test == false)
     | select(.package_id as $pid
       | '"${members}"'
@@ -42,7 +44,7 @@ function installFromCargoBuildLog() (
     mkdir -p "${loc}"
 
     while IFS= read -r to_install; do
-      echo installing ${to_install} in "${loc}"
+      echo "installing ${to_install} in ${loc}"
       cp "${to_install}" "${loc}"
     done
 
@@ -59,7 +61,7 @@ function installFromCargoBuildLog() (
 # we are planning to install (see https://github.com/ipetkov/crane/issues/765). To work around
 # this we'll capture any installables immediately after running and actually install them later
 function postBuildInstallFromCargoBuildLog() (
-  if [ -n "${cargoBuildLog:-}" -a -f "${cargoBuildLog}" ]; then
+  if [ -n "${cargoBuildLog:-}" ] && [ -f "${cargoBuildLog}" ]; then
     installFromCargoBuildLog "${postBuildInstallFromCargoBuildLogOut}" "${cargoBuildLog}"
   else
     cat <<-'EOF'