fix: propagate trailer errors correctly (#636)

* fix: propagate trailer errors correctly

* test: fix CRLFs for fixture files

Author: dryajov

appveyor.yml

@@ -3,6 +3,9 @@ environment:
     - nodejs_version: "6"
     - nodejs_version: "8"
 
+init:
+  - git config --global core.autocrlf input
+
 # cache:
 #  - node_modules
 

src/utils/send-files-stream.js

@@ -129,6 +129,8 @@ module.exports = (send, path) => {
         return
       }
 
+      response.on('error', (err) => retStream.emit('error', err))
+
       response.on('data', (d) => {
         if (d.Bytes && options.progress) {
           options.progress(d.Bytes)

src/utils/send-request.js

@@ -47,28 +47,16 @@ function onRes (buffer, cb) {
     // Return a stream of JSON objects
     if (chunkedObjects && isJson) {
       const outputStream = pump(res, ndjson.parse())
-      // TODO: This needs reworking.
-      // this is a chicken and egg problem -
-      // 1) we can't get Trailer headers unless the response ends
-      // 2) we can't propagate the error, because the response stream
-      // is closed
-      // (perhaps we can workaround this using pull-streams)
       res.on('end', () => {
         let err = res.trailers['x-stream-error']
         if (err) {
           // Not all errors are JSON
           try {
             err = JSON.parse(err)
           } catch (e) {
-            err = {
-              Code: 'n/a',
-              Message: err
-            }
+            err = { Message: err }
           }
-          const error = new Error(`Server responded with 500`)
-          error.code = err.Code
-          error.message = err.Message
-          outputStream.destroy(error) // error is not going to be propagated
+          outputStream.emit('error', new Error(err.Message))
         }
       })
       return cb(null, outputStream)