chore: address pr comments

Author: achingbrain

package.json

@@ -107,7 +107,7 @@
     "browser-process-platform": "~0.1.1",
     "cross-env": "^6.0.0",
     "go-ipfs-dep": "^0.4.22",
-    "interface-ipfs-core": "ipfs/interface-js-ipfs-core#30118c715d95582eaf65fdf8cb0ee240c504cb1e",
+    "interface-ipfs-core": "^0.117.0",
     "ipfsd-ctl": "^0.47.1",
     "nock": "^11.3.2",
     "stream-equal": "^1.1.1"

src/config/index.js

@@ -6,7 +6,7 @@ module.exports = (send, config) => {
     set: require('./set')(send),
     replace: require('./replace')(send),
     profiles: {
-      apply: require('./profiles/apply')(send),
+      apply: require('./profiles/apply')(config),
       list: require('./profiles/list')(config)
     }
   }

src/config/profiles/apply.js

@@ -1,41 +1,27 @@
 'use strict'
 
-const promisify = require('promisify-es6')
+const callbackify = require('callbackify')
+const configure = require('../../lib/configure')
 
-const toObject = function (res, callback) {
-  if (Buffer.isBuffer(res)) {
-    callback(null, JSON.parse(res.toString()))
-  } else {
-    callback(null, res)
-  }
-}
+module.exports = configure(({ ky }) => {
+  return callbackify.variadic(async (profile, options) => {
+    options = options || {}
 
-module.exports = (send) => {
-  return promisify((profile, opts, callback) => {
-    if (typeof opts === 'function') {
-      callback = opts
-      opts = {}
-    }
-
-    opts = normalizeOpts(opts)
-
-    send.andTransform({
-      path: 'config/profile/apply',
-      args: profile,
-      qs: opts
-    }, toObject, (err, response) => {
-      if (err) {
-        return callback(err)
+    const res = await ky.post('config/profile/apply', {
+      timeout: options.timeout,
+      signal: options.signal,
+      headers: options.headers,
+      searchParams: {
+        arg: profile,
+        // can only pass strings or numbers as values https://github.com/sindresorhus/ky/issues/182
+        'dry-run': options.dryRun ? 'true' : 'false'
       }
-      callback(null, { old: response.OldCfg, new: response.NewCfg })
     })
-  })
-}
 
-function normalizeOpts (opts) {
-  opts = opts || {}
-  if (typeof opts.dryRun !== 'undefined') {
-    opts['dry-run'] = opts.dryRun
-  }
-  return opts
-}
+    const parsed = await res.json()
+
+    return {
+      original: parsed.OldCfg, updated: parsed.NewCfg
+    }
+  })
+})

src/config/profiles/list.js

@@ -1,21 +1,17 @@
 'use strict'
 
-const configure = require('../../lib/configure')
 const callbackify = require('callbackify')
+const configure = require('../../lib/configure')
 const toCamel = require('../../lib/object-to-camel')
 
 module.exports = configure(({ ky }) => {
   return callbackify.variadic(async (options) => {
     options = options || {}
 
-    const searchParams = new URLSearchParams(options.searchParams)
-    searchParams.set('stream-channels', true)
-
     const res = await ky.get('config/profile/list', {
       timeout: options.timeout,
       signal: options.signal,
-      headers: options.headers,
-      searchParams
+      headers: options.headers
     })
 
     const parsed = await res.json()