Skip to content

dist.sh should check that the new version is newer than the current version #319

New issue
New issue
Open
#376
Open
dist.sh should check that the new version is newer than the current version#319
#376
Labels
P2Medium: Good to have, but can wait until someone steps updif/easySomeone with a little familiarity can pick upeffort/hoursEstimated to take one or several hoursgood first issueGood issue for new contributorshelp wantedSeeking public contribution on this issuekind/maintenanceWork required to avoid breaking changes or harm to project's status quostatus/readyReady to be worked
Milestone
Best Effort Track
@olizilla

Description

@olizilla
olizilla
opened on Oct 23, 2020

A note-to-self to make dist.sh verify that the new-version is in fact newer in semver terms than the current version... we avoid setting release candidates as current, but we dont guard against setting older versions as current. Minor but feels like a foot gun.

distributions/dist.sh

Lines 58 to 63 in 211588d

case "$nvers" in
*-*) echo "WARNING: not marking pre-release $dist $nvers as the current version." ;;
*) echo "$nvers" > "dists/$dist/current" ;;
esac
echo "$nvers" >> "dists/$dist/versions"

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium: Good to have, but can wait until someone steps updif/easySomeone with a little familiarity can pick upeffort/hoursEstimated to take one or several hoursgood first issueGood issue for new contributorshelp wantedSeeking public contribution on this issuekind/maintenanceWork required to avoid breaking changes or harm to project's status quostatus/readyReady to be worked

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions