go-migrate/cli: ensure non 0 exit code if -path is missing

chriscool · chriscool · commit 36a323353e01 · 2016-07-13T22:59:22.000+02:00
diff --git a/go-migrate/cli.go b/go-migrate/cli.go
@@ -31,7 +31,7 @@ func Run(m Migration) error {
 
 	if f.Path == "" {
 		flag.Usage()
-		return nil
+		return fmt.Errorf("missing or empty path; flag '-path <ipfs_path>' is required")
 	}
 
 	if !m.Reversible() {
diff --git a/sharness/t0080-migration-3-to-4.sh b/sharness/t0080-migration-3-to-4.sh
@@ -223,6 +223,10 @@ test_expect_success "get pin lists" '
 	ipfs pin ls --type=indirect | sort > more_start_ind_pins
 '
 
+test_expect_success "'ipfs-3-to-4 -revert' fails without -path" '
+	test_must_fail ipfs-3-to-4 -revert
+'
+
 test_expect_success "'ipfs-3-to-4 -revert' succeeds" '
 	ipfs-3-to-4 -revert -path="$IPFS_PATH" >actual
 '

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ func Run(m Migration) error {`
`31`	`31`
`32`	`32`	`if f.Path == "" {`
`33`	`33`	`flag.Usage()`
`34`		`- return nil`
	`34`	`+ return fmt.Errorf("missing or empty path; flag '-path <ipfs_path>' is required")`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`if !m.Reversible() {`
Original file line number	Diff line number	Diff line change
`@@ -223,6 +223,10 @@ test_expect_success "get pin lists" '`
`223`	`223`	`ipfs pin ls --type=indirect \| sort > more_start_ind_pins`
`224`	`224`	`'`
`225`	`225`
	`226`	`+test_expect_success "'ipfs-3-to-4 -revert' fails without -path" '`
	`227`	`+ test_must_fail ipfs-3-to-4 -revert`
	`228`	`+'`
	`229`	`+`
`226`	`230`	`test_expect_success "'ipfs-3-to-4 -revert' succeeds" '`
`227`	`231`	`ipfs-3-to-4 -revert -path="$IPFS_PATH" >actual`
`228`	`232`	`'`