@@ -16,12 +16,12 @@ import (
1616//go:generate go run ./cmd/generate
1717
1818// openers contains the known datastore implementations.
19- var openers map [string ]func (string ) ds.TxnDatastore
19+ var openers map [string ]func (string ) ds.Datastore
2020
2121// AddOpener allows registration of a new driver for fuzzing.
22- func AddOpener (name string , opener func (loc string ) ds.TxnDatastore ) {
22+ func AddOpener (name string , opener func (loc string ) ds.Datastore ) {
2323 if openers == nil {
24- openers = make (map [string ]func (string ) ds.TxnDatastore )
24+ openers = make (map [string ]func (string ) ds.Datastore )
2525 }
2626 openers [name ] = opener
2727}
@@ -32,14 +32,16 @@ var Threads int
3232
3333func init () {
3434 if openers == nil {
35- openers = make (map [string ]func (string ) ds.TxnDatastore )
35+ openers = make (map [string ]func (string ) ds.Datastore )
3636 }
3737 Threads = 1
3838}
3939
4040// RunState encapulates the state of a given fuzzing run
4141type RunState struct {
42- inst ds.TxnDatastore
42+ inst ds.Datastore
43+ // opMax signals which operations the instance supports.
44+ opMax op
4345 inputChannels []chan <- byte
4446 wg sync.WaitGroup
4547 Cancel context.CancelFunc
@@ -50,10 +52,18 @@ type RunState struct {
5052}
5153
5254// DB returns the datastore being driven by this instance
53- func (r * RunState ) DB () ds.TxnDatastore {
55+ func (r * RunState ) DB () ds.Datastore {
5456 return r .inst
5557}
5658
59+ // TxnDB returns the transaciton database if the store under test supports transactions
60+ func (r * RunState ) TxnDB () ds.TxnDatastore {
61+ if txdb , ok := r .inst .(ds.TxnDatastore ); ok {
62+ return txdb
63+ }
64+ return nil
65+ }
66+
5767type threadState struct {
5868 op
5969 keyReady bool
@@ -78,6 +88,11 @@ func Open(driver string, location string, cleanup bool) (*RunState, error) {
7888
7989 state := RunState {}
8090 state .inst = opener (location )
91+ state .opMax = opMax
92+ // don't attempt transaction operations on non-txn datastores.
93+ if state .TxnDB () == nil {
94+ state .opMax = opNewTX
95+ }
8196 state .keyCache [0 ] = ds .NewKey ("/" )
8297 state .cachedKeys = 1
8398
@@ -146,7 +161,7 @@ func FuzzDB(driver string, location string, cleanup bool, data []byte) int {
146161
147162// FuzzStream does the same as fuzz but with streaming input
148163func FuzzStream (driver string , location string , cleanup bool , data io.Reader ) error {
149- inst , err := Open ("badger" , "tmp" , true )
164+ inst , err := Open (driver , location , cleanup )
150165 if err != nil {
151166 return err
152167 }
@@ -185,10 +200,10 @@ const (
185200 opQuery
186201 opPut
187202 opDelete
203+ opSync
188204 opNewTX
189205 opCommitTX
190206 opDiscardTX
191- opSync
192207 opMax
193208)
194209
@@ -214,7 +229,7 @@ func threadDriver(ctx context.Context, runState *RunState, cmnds chan byte) {
214229
215230func nextState (s * threadState , c byte ) error {
216231 if s .op == opNone {
217- s .op = op (c ) % opMax
232+ s .op = op (c ) % s . RunState . opMax
218233 return nil
219234 } else if s .op == opGet {
220235 if ! s .keyReady {
@@ -267,11 +282,13 @@ func nextState(s *threadState, c byte) error {
267282 return nil
268283 } else if s .op == opNewTX {
269284 if s .txn == nil {
270- s .txn , _ = s .RunState .inst .NewTransaction (((c & 1 ) == 1 ))
271- if (c & 1 ) != 1 { // read+write
272- s .writer = s .txn
285+ if tdb := s .RunState .TxnDB (); tdb != nil {
286+ s .txn , _ = tdb .NewTransaction (((c & 1 ) == 1 ))
287+ if (c & 1 ) != 1 { // read+write
288+ s .writer = s .txn
289+ }
290+ s .reader = s .txn
273291 }
274- s .reader = s .txn
275292 }
276293 reset (s )
277294 return nil
0 commit comments