Skip to content

Commit 7594c11

Browse files
disable dedup cache by default (#20)
* disable dedup cache by default
1 parent 5830344 commit 7594c11

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

dsqueue.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,9 @@ func (q *DSQueue) worker(ctx context.Context, bufferSize, dedupCacheSize int, id
367367
idle = false
368368
rmMemCount += inBuf.Len()
369369
inBuf.Clear()
370-
dedupCache.Purge()
370+
if dedupCache != nil {
371+
dedupCache.Purge()
372+
}
371373
rmDSCount, err := q.clearDatastore(ctx)
372374
if err != nil {
373375
log.Errorw("cannot clear datastore", "err", err, "qname", q.name)

dsqueue_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ func TestPersistOneCid(t *testing.T) {
297297

298298
func TestDeduplicateCids(t *testing.T) {
299299
ds := sync.MutexWrap(datastore.NewMapDatastore())
300-
queue := dsqueue.New(ds, dsqName)
300+
queue := dsqueue.New(ds, dsqName, dsqueue.WithDedupCacheSize(2*1024))
301301
defer queue.Close()
302302

303303
cids := random.Cids(5)

option.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@ import (
55
)
66

77
const (
8-
DefaultBufferSize = 16 * 1024
9-
DefaultDedupCacheSize = 2 * 1024
10-
DefaultIdleWriteTime = time.Minute
11-
DefaultCloseTimeout = 10 * time.Second
8+
DefaultBufferSize = 16 * 1024
9+
DefaultIdleWriteTime = time.Minute
10+
DefaultCloseTimeout = 10 * time.Second
1211
)
1312

1413
// config contains all options for DSQueue.
@@ -25,10 +24,9 @@ type Option func(*config)
2524
// getOpts creates a config and applies Options to it.
2625
func getOpts(opts []Option) config {
2726
cfg := config{
28-
bufferSize: DefaultBufferSize,
29-
dedupCacheSize: DefaultDedupCacheSize,
30-
idleWriteTime: DefaultIdleWriteTime,
31-
closeTimeout: DefaultCloseTimeout,
27+
bufferSize: DefaultBufferSize,
28+
idleWriteTime: DefaultIdleWriteTime,
29+
closeTimeout: DefaultCloseTimeout,
3230
}
3331

3432
for _, opt := range opts {
@@ -52,7 +50,9 @@ func WithBufferSize(n int) Option {
5250
}
5351

5452
// WithDedupCacheSize sets the size of the LRU cache used to deduplicate items
55-
// in the queue. A value of 0 disables the dedup cache.
53+
// in the queue.
54+
//
55+
// By default, the deduplication cache is disabled (size = 0).
5656
func WithDedupCacheSize(n int) Option {
5757
return func(c *config) {
5858
if n < 0 {

0 commit comments

Comments
 (0)