cleanup: report test setup failures, fix staticcheck failures

Author: iand

ipns_test.go

@@ -6,8 +6,12 @@ import (
 	"time"
 )
 
-var examplesHashForIPNS = "/ipfs/Qmbu7x6gJbsKDcseQv66pSbUcAA3Au6f7MfTYVXwvBxN2K"
-var testKey = "self" // feel free to change to whatever key you have locally
+var (
+	//lint:ignore U1000 used only by skipped tests at present
+	examplesHashForIPNS = "/ipfs/Qmbu7x6gJbsKDcseQv66pSbUcAA3Au6f7MfTYVXwvBxN2K"
+	//lint:ignore U1000 used only by skipped tests at present
+	testKey = "self" // feel free to change to whatever key you have locally
+)
 
 func TestPublishDetailsWithKey(t *testing.T) {
 	t.Skip()

mfs_test.go

@@ -17,17 +17,20 @@ func TestMain(m *testing.M) {
 	for _, f := range files {
 		file, err := os.Open(fmt.Sprintf("./testdata/%s", f))
 		if err != nil {
+			fmt.Fprintf(os.Stderr, "Failed to open test data file: %v\n", err)
 			os.Exit(1)
 		}
 
 		err = s.FilesWrite(context.Background(), fmt.Sprintf("/testdata/%s", f), file, FilesWrite.Parents(true), FilesWrite.Create(true))
 		if err != nil {
+			fmt.Fprintf(os.Stderr, "Failed to write test data, not running tests: %v\n", err)
 			os.Exit(1)
 		}
 	}
 
 	exitVal := m.Run()
 	if err := s.FilesRm(context.Background(), "/testdata", true); err != nil {
+		fmt.Fprintf(os.Stderr, "Failed to remove test data: %v\n", err)
 		os.Exit(1)
 	}
 	os.Exit(exitVal)
@@ -115,7 +118,7 @@ func TestFilesMv(t *testing.T) {
 	is.Nil(err)
 	is.Equal(stat.Hash, "QmfZt7xPekp7npSM6DHDUnFseAiNZQs7wq6muH9o99RsCB")
 
-	stat, err = s.FilesStat(context.Background(), "/testdata/readme")
+	_, err = s.FilesStat(context.Background(), "/testdata/readme")
 	is.NotNil(err)
 
 	err = s.FilesMv(context.Background(), "/testdata/readme2", "/testdata/readme")
@@ -184,6 +187,8 @@ func TestFilesWrite(t *testing.T) {
 	is.Equal(string(resBytes), "ipfs")
 
 	file, err = ioutil.ReadFile("./testdata/ping")
+	is.Nil(err)
+
 	err = s.FilesWrite(context.Background(), "/testdata/ping", bytes.NewBuffer(file), FilesWrite.Offset(0), FilesWrite.Count(2), FilesWrite.Truncate(true))
 	is.Nil(err)
 

shell.go

@@ -19,7 +19,7 @@ import (
 	files "github.com/ipfs/go-ipfs-files"
 	homedir "github.com/mitchellh/go-homedir"
 	ma "github.com/multiformats/go-multiaddr"
-	manet "github.com/multiformats/go-multiaddr-net"
+	manet "github.com/multiformats/go-multiaddr/net"
 	tar "github.com/whyrusleeping/tar-utils"
 
 	p2pmetrics "github.com/libp2p/go-libp2p-core/metrics"
@@ -147,7 +147,7 @@ type IdOutput struct {
 //   return information about the local peer.
 func (s *Shell) ID(peer ...string) (*IdOutput, error) {
 	if len(peer) > 1 {
-		return nil, fmt.Errorf("Too many peer arguments")
+		return nil, fmt.Errorf("too many peer arguments")
 	}
 
 	var out IdOutput