Pass less filehandle metadata in the case of a fifo

ribasushi · ribasushi · commit 943a0f7553da · 2020-03-16T13:45:19.000+01:00
diff --git a/cli/parse.go b/cli/parse.go
@@ -518,7 +518,12 @@ func appendFile(fpath string, argDef *cmds.Argument, recursive, hidden bool) (fi
 		if err != nil {
 			return nil, err
 		}
-		return files.NewReaderPathFile(fpath, file, stat)
+
+		return files.NewReaderPathFile(
+			"", // the path string should only refer to files that can actually be read. The filestore/urlstore features will use it
+			file,
+			nil, // normally the passed through stat will be used to determine the size of the file. It'll give us very incorrect information in this case
+		)
 	}
 
 	return files.NewSerialFile(fpath, hidden, stat)

Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,12 @@ func appendFile(fpath string, argDef *cmds.Argument, recursive, hidden bool) (fi`
`518`	`518`	`if err != nil {`
`519`	`519`	`return nil, err`
`520`	`520`	`}`
`521`		`- return files.NewReaderPathFile(fpath, file, stat)`
	`521`	`+`
	`522`	`+ return files.NewReaderPathFile(`
	`523`	`+ "", // the path string should only refer to files that can actually be read. The filestore/urlstore features will use it`
	`524`	`+ file,`
	`525`	`+ nil, // normally the passed through stat will be used to determine the size of the file. It'll give us very incorrect information in this case`
	`526`	`+ )`
`522`	`527`	`}`
`523`	`528`
`524`	`529`	`return files.NewSerialFile(fpath, hidden, stat)`