Skip to content

Batch is not thread safe #47

@hsanjuan

Description

@hsanjuan

Looking at batch code, it using an activeCommits int and size int counters very liberally all over the place. Calling Add(), at the same time as Commit() seems likely to trigger weird side effects: i.e. size reset to 0 when it should not, or activeCommits potentially going on the negative.

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedSeeking public contribution on this issuekind/enhancementA net-new feature or improvement to an existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions