Skip to content

Import DAG reader tests involving NodePromises to actually test NavigableIPLDNode #50

@schomatis

Description

@schomatis

The node prefetching mechanism has been abstracted away from the DAG reader in go-unixfs into the NavigableIPLDNode here, so the PR ipfs/go-unixfs#12 which employs the Walker (that relies on NavigableIPLDNode) had to remove the related tests that acted directly on the internal NodePromise structure,

https://github.com/ipfs/go-unixfs/pull/12/files#diff-5a645da404e1845b770b90d1c81e71c6

Those tests should be recreated here (possibly without involving the DAG reader now, just testing the FetchChild and related methods of NavigableIPLDNode to actually create the NodePromises following the spirit of the original test).

Metadata

Metadata

Assignees

No one assigned

    Labels

    exp/noviceSomeone with a little familiarity can pick uphelp wantedSeeking public contribution on this issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions