chore: reduce number of changes

Author: SgtPooki

packages/client/.aegir.js

@@ -22,20 +22,16 @@ const options = {
       echo.polka.post('/add-providers/:cid', (req, res) => {
         callCount++
         try {
-          if (!req.headers['content-type']?.includes('application/json')) {
-            res.statusCode = 400
-            res.end(JSON.stringify({
-              error: 'Invalid content type. Expected application/json',
-              code: 'ERR_INVALID_INPUT'
-            }))
-            providers.delete(req.params.cid)
-            return
+
+          let data
+          try {
+            // when passed data from a test where `body=providers.map(prov => JSON.stringify(prov)).join('\n')`
+            data = { Providers: req.body.split('\n').map(line => JSON.parse(line)) }
+          } catch (err) {
+            // when passed data from a test where `body=JSON.stringify({ Providers: providers })`
+            data = req.body
           }
-      
-          const data = typeof req.body === 'string' 
-            ? { Providers: req.body.split('\n').map(line => JSON.parse(line)) }
-            : req.body
-      
+
           providers.set(req.params.cid, data)
           res.end(JSON.stringify({ success: true }))
         } catch (err) {
@@ -53,7 +49,7 @@ const options = {
         try {
           const providerData = providers.get(req.params.cid) || { Providers: [] }
           const acceptHeader = req.headers.accept
-      
+
           if (acceptHeader?.includes('application/x-ndjson')) {
             res.setHeader('Content-Type', 'application/x-ndjson')
             const providers = Array.isArray(providerData.Providers) ? providerData.Providers : []

packages/client/test/index.spec.ts

@@ -52,10 +52,7 @@ describe('delegated-routing-v1-http-api-client', () => {
     // load providers for the router to fetch
     await fetch(`${process.env.ECHO_SERVER}/add-providers/${cid.toString()}`, {
       method: 'POST',
-      headers: {
-        'Content-Type': 'application/json'
-      },
-      body: JSON.stringify({ Providers: providers })
+      body: providers.map(prov => JSON.stringify(prov)).join('\n')
     })
 
     const provs = await all(client.getProviders(cid))
@@ -103,26 +100,6 @@ describe('delegated-routing-v1-http-api-client', () => {
     }
   })
 
-  it('should handle non-json input', async () => {
-    const cid = CID.parse('QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn')
-
-    const response = await fetch(`${process.env.ECHO_SERVER}/add-providers/${cid.toString()}`, {
-      method: 'POST',
-      headers: {
-        'Content-Type': 'text/plain'
-      },
-      body: 'not json'
-    })
-
-    expect(response.status).to.equal(400)
-    const errorData = await response.json()
-    expect(errorData).to.have.property('error')
-    expect(errorData).to.have.property('code', 'ERR_INVALID_INPUT')
-
-    const provs = await all(client.getProviders(cid))
-    expect(provs).to.be.empty()
-  })
-
   it('should add filter parameters the query of the request url', async () => {
     const providers = [{
       Protocol: 'transport-bitswap',
@@ -180,7 +157,7 @@ describe('delegated-routing-v1-http-api-client', () => {
     expect(searchParams.get('filter-addrs')).to.equal('tcp,!p2p-circuit')
   })
 
-  it('should handle non-json input without content-type header', async () => {
+  it('should handle non-json input', async () => {
     const cid = CID.parse('QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn')
 
     // load providers for the router to fetch
@@ -375,10 +352,7 @@ describe('delegated-routing-v1-http-api-client', () => {
     // load providers for the router to fetch
     await fetch(`${process.env.ECHO_SERVER}/add-providers/${cid.toString()}`, {
       method: 'POST',
-      headers: {
-        'Content-Type': 'application/json'
-      },
-      body: JSON.stringify({ Providers: providers })
+      body: providers.map(prov => JSON.stringify(prov)).join('\n')
     })
 
     // Reset call count before our test
@@ -431,10 +405,7 @@ describe('delegated-routing-v1-http-api-client', () => {
     // load providers for the router to fetch
     await fetch(`${process.env.ECHO_SERVER}/add-providers/${cid.toString()}`, {
       method: 'POST',
-      headers: {
-        'Content-Type': 'application/json'
-      },
-      body: JSON.stringify({ Providers: providers })
+      body: providers.map(prov => JSON.stringify(prov)).join('\n')
     })
 
     // Reset call count

packages/client/test/routings.spec.ts

@@ -69,10 +69,7 @@ describe('libp2p content-routing', () => {
     // load providers for the router to fetch
     await fetch(`${process.env.ECHO_SERVER}/add-providers/${cid.toString()}`, {
       method: 'POST',
-      headers: {
-        'Content-Type': 'application/json'
-      },
-      body: JSON.stringify({ Providers: providers })
+      body: providers.map(prov => JSON.stringify(prov)).join('\n')
     })
 
     const provs = await all(routing.findProviders(cid))