Skip to content

Conversation

@SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 12, 2025

Title

test: conformance testing more modular, no hangs

Description

Fixes an issue where gateway conformance tests were hanging in #261. Separates the gwc binary run from the actual unit tests on it's results.

Related #261

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@SgtPooki SgtPooki requested a review from a team as a code owner September 12, 2025 17:39
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

if (options.runner !== 'node') {
throw new Error('Only node runner is supported')
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was all moved inside generate-conformance-report.ts

@SgtPooki SgtPooki merged commit ae6e463 into main Sep 12, 2025
23 checks passed
@SgtPooki SgtPooki deleted the fix/conformance-test-hang branch September 12, 2025 18:34
github-actions bot pushed a commit that referenced this pull request Sep 12, 2025
## [@helia/verified-fetch-v3.2.1](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-3.2.0...@helia/verified-fetch-3.2.1) (2025-09-12)

### Tests

* conformance testing more modular, no hangs ([#266](#266)) ([ae6e463](ae6e463))
@github-actions
Copy link

🎉 This PR is included in version @helia/verified-fetch-v3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Sep 12, 2025
## [@helia/verified-fetch-gateway-conformance-v1.5.1](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-gateway-conformance-1.5.0...@helia/verified-fetch-gateway-conformance-1.5.1) (2025-09-12)

### Tests

* conformance testing more modular, no hangs ([#266](#266)) ([ae6e463](ae6e463))
@github-actions
Copy link

🎉 This PR is included in version @helia/verified-fetch-gateway-conformance-v1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Sep 12, 2025
## [@helia/verified-fetch-interop-v1.26.3](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-interop-1.26.2...@helia/verified-fetch-interop-1.26.3) (2025-09-12)

### Tests

* conformance testing more modular, no hangs ([#266](#266)) ([ae6e463](ae6e463))
@github-actions
Copy link

🎉 This PR is included in version @helia/verified-fetch-interop-v1.26.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants