Skip to content

Commit 6dbfa13

Browse files
andrewlidel
andauthored
feat: enable pubsub via settings menu (#1735)
* Allow enabling pubsub setting via tray preferences * refactor: pubsub toggle triggers restart * chore: ipfsd-ctl v7.2.0 ipfsd.stop() did not wait for proper shutdown, which caused things to go racy during situations where we restart node. When unlucky, I ended up with two go-ipfs processses. Bumping version to include fix from ipfs/js-ipfsd-ctl#554 * fix: show pubsub status when starting * refactor: avoid duplicated pubsub in logs already logged in ./src/utils/create-toggler.js, so here we only log status when app starts and that is all * refactor: move pubsub to experiments it is still an experiment in go-ipfs: https://github.com/ipfs/go-ipfs/blob/master/docs/experimental-features.md#ipfs-pubsub * refactor: simplify pubsub enable/disable Co-authored-by: Marcin Rataj <[email protected]>
1 parent de2f752 commit 6dbfa13

File tree

7 files changed

+274
-104
lines changed

7 files changed

+274
-104
lines changed

assets/locales/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@
223223
"appPreferences": "App Preferences",
224224
"launchOnStartup": "Launch at Login",
225225
"openWebUIAtLaunch": "Open Web UI at Launch",
226+
"pubsub": "Enable PubSub",
226227
"ipfsCommandLineTools": "Command Line Tools",
227228
"takeScreenshotShortcut": "Global Screenshot Shortcut",
228229
"downloadHashShortcut": "Global Download Shortcut",

0 commit comments

Comments
 (0)