-
Notifications
You must be signed in to change notification settings - Fork 461
Switch plaintext sections #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The two plaintext sections have been placed incorrectly. Now that I switched them, the whole paragraph makes sense again.
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
TMoMoreau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me.
|
Sorry, accidentally closed this a few minutes ago. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SebastianSupreme thank you for taking the time read our docs and open this pull request.
After reviewing this PR / merging in the latest from main, I would propose that a change before this is merged: 51182c1. I do understand the confusion here that prompted this PR, but I do not think the plaintext sections should be switched - I think that they were in the correct location, but the writing and section formatting / structure made it unclear. Your PR indicates that this page needs improvement. So, in the commit above, I regrouped, rewrote and rearranged some of the content in the section to hopefully better clarify the different ways to construct path URLs given an IPFS id. I may be incorrect here, but this is the way I am interpreting this section.
The draft is here https://bafybeig5irfij4ehycf2sr5mslnfpsp5th73vmj5kpfa3k4oxokcejbigq.on.fleek.co/how-to/address-ipfs-on-web/#path-gateway
Hopefully this addresses the issue here. Thank you for the PR and the feedback, and apologies for the confusion here.
This example somehow ended up in the ipns section which needs a new example now. 🤷♂️
|
@ElPaisano Thank you for your time to review my PR. |
|
@2color could you take a quick look at this draft / PR and let us know if you think the latest updates are the correct resolution? |
|
@ElPaisano This was a misunderstanding of the doc on my part, after reading the page again and getting a better understanding of the content, your changes make sense. I'm going to do one more quick pass and approve again. |
|
@ElPaisano @TMoMoreau |
Describe your changes
The two plaintext sections have been placed incorrectly.
Now that I switched them, the whole paragraph makes sense again.
Files changed
docs/how-to/address-ipfs-on-web.md
Does this update depend on any other PRs?
No.