-
Notifications
You must be signed in to change notification settings - Fork 24
Closed
Labels
kind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)need/triageNeeds initial labeling and prioritizationNeeds initial labeling and prioritization
Description
Describe the bug
Walking into a file makes it impossible to navigate further due to no path label to click.
To Reproduce
- Go to https://explore.ipld.io/#/explore/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D/albums/QXBvbGxvIDE0IE1hZ2F6aW5lIDY0L0xM/21076550124_dfaa21d664_o.jpg (Apollo Archives Example)
- Click on any chunk, eg. 0 or 1
- See that nothing happens, only a breadcrumb is added, but navigation does not happen
Expected behavior
Clicking on a node without Path should still work, and navigate to respective child chunk.
Screenshots
Additional context
- This happens in https://github.com/ipfs/ipfs-webui/releases/tag/v4.4.0 as well (http://127.0.0.1:5001/ipfs/bafybeibgic2ex3fvzkinhy6k6aqyv3zy2o7bkbsmrzvzka24xetv7eeadm/#/explore/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D/albums/QXBvbGxvIDE0IE1hZ2F6aW5lIDY0L0xM/21076550124_dfaa21d664_o.jpg)
- I think in the past we avoided this bug by creating "fake path" labels named "Link-1" or something like that, maybe we should just reuse CID?
- Sidenote: I vaguely remember that in past we've discussed avoiding infinite breadcrumbs growing too long, and had idea to only keep last 2 parents.
SgtPooki2color and SgtPooki
Metadata
Metadata
Assignees
Labels
kind/bugA bug in existing code (including security flaws)A bug in existing code (including security flaws)need/triageNeeds initial labeling and prioritizationNeeds initial labeling and prioritization
