This repository was archived by the owner on Sep 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Replace manual traversal with ipfs.resolveΒ #14
Copy link
Copy link
Open
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upexp/expertHaving worked on the specific codebase is importantHaving worked on the specific codebase is importanthelp wantedSeeking public contribution on this issueSeeking public contribution on this issuestatus/readyReady to be workedReady to be worked
Description
AFAIK at the time this project was created ipfs.resolve was not present in js-ipfs, and we had to do the traversal manually.
Since then ipfs.resolve landed in js-ipfs so this may be worth checking.
js-ipfs-http-response/src/resolver.js
Lines 56 to 57 in 076fde3
| // TODO: replace below with ipfs.resolve(path, {recursive: true}) | |
| // (requires changes to js-ipfs/js-ipfs-api) |
Things to check:
- does
resolvework the same in go-ipfs and js-ipfs (eg. how HAMT directories are handled) - it should transparently take care of sharded directories
vasco-santos
Metadata
Metadata
Assignees
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upexp/expertHaving worked on the specific codebase is importantHaving worked on the specific codebase is importanthelp wantedSeeking public contribution on this issueSeeking public contribution on this issuestatus/readyReady to be workedReady to be worked