feat: better error message on ipfs cat

`ipfs cat <hash>/wrong-dir/wrong-file` previously
returned: 'No such file'.

this commit changes the error message to:
'no file named "wrong-dir/wrong-file" under <hash>'

License: MIT
Signed-off-by: Nitin Patel <[email protected]>

Author: niinpatel

src/core/components/files-regular/cat-pull-stream.js

@@ -14,8 +14,11 @@ module.exports = function (self) {
     options = options || {}
 
     ipfsPath = normalizePath(ipfsPath)
+
     const pathComponents = ipfsPath.split('/')
     const fileNameOrHash = pathComponents[pathComponents.length - 1]
+    const cid = pathComponents[0]
+    const filePath = pathComponents.slice(1).join('/')
 
     if (options.preload !== false) {
       self._preload(pathComponents[0])
@@ -33,7 +36,7 @@ module.exports = function (self) {
         }
 
         if (!files.length) {
-          return d.abort(new Error('No such file'))
+          return d.abort(new Error(`no file named "${filePath}" under ${cid}`))
         }
 
         const file = files[0]

test/cli/files.js

@@ -436,6 +436,16 @@ describe('files', () => runOnAndOff((thing) => {
       .then(() => expect.fail(0, 1, 'Should have thrown an error'))
       .catch((err) => {
         expect(err).to.exist()
+        expect(err.stdout).to.contain('no file named "dummy" under QmPZ9gcCEpqKTo6aq61g2nXGUhM4iCL3ewB6LDXZCtioEB')
+      })
+  })
+
+  it('cat non-existent file (nested)', () => {
+    return ipfs('cat QmPZ9gcCEpqKTo6aq61g2nXGUhM4iCL3ewB6LDXZCtioEB/wrong-dir/wrong-file')
+      .then(() => expect.fail(0, 1, 'Should have thrown an error'))
+      .catch((err) => {
+        expect(err).to.exist()
+        expect(err.stdout).to.contain('no file named "wrong-dir/wrong-file" under QmPZ9gcCEpqKTo6aq61g2nXGUhM4iCL3ewB6LDXZCtioEB')
       })
   })