fix: name resolve arg parsing (#1958)

Boolean args were not being parsed as booleans.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>

Author: Alan Shaw

src/cli/commands/daemon.js

@@ -20,6 +20,7 @@ module.exports = {
         default: false
       })
       .option('offline', {
+        type: 'boolean',
         desc: 'Run offline. Do not connect to the rest of the network but provide local API.',
         default: false
       })

src/cli/commands/name/resolve.js

@@ -9,13 +9,15 @@ module.exports = {
 
   builder: {
     nocache: {
+      type: 'boolean',
       alias: 'n',
       describe: 'Do not use cached entries. Default: false.',
       default: false
     },
     recursive: {
+      type: 'boolean',
       alias: 'r',
-      recursive: 'Resolve until the result is not an IPNS name. Default: false.',
+      describe: 'Resolve until the result is not an IPNS name. Default: false.',
       default: false
     }
   },

test/cli/name.js

@@ -158,8 +158,7 @@ describe('name', () => {
         })
     })
 
-    // FIXME: currently failing, resolve before 0.35 release!
-    it.skip('should go recursively until finding an ipfs hash', function () {
+    it('should go recursively until finding an ipfs hash', function () {
       this.timeout(90 * 1000)
 
       return ipfs(`name publish ${cidAdded}`)