Skip to content

Commit 93a0637

Browse files
authored
fix: use fetch in electron renderer and electron-fetch in main (#3251)
Lets us run test on Linux which roughly halves the amount of time Electron CI tasks take.
1 parent 916fe40 commit 93a0637

File tree

13 files changed

+19
-15
lines changed

13 files changed

+19
-15
lines changed

package.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,13 @@
4040
"dep-check": "aegir dep-check"
4141
},
4242
"dependencies": {
43-
"abort-controller": "^3.0.0",
4443
"any-signal": "^2.0.0",
4544
"bignumber.js": "^9.0.0",
4645
"cids": "^1.0.0",
4746
"debug": "^4.1.1",
4847
"form-data": "^3.0.0",
4948
"ipfs-core-utils": "^0.4.0",
50-
"ipfs-utils": "^3.0.0",
49+
"ipfs-utils": "^4.0.0",
5150
"ipld-block": "^0.10.1",
5251
"ipld-dag-cbor": "^0.17.0",
5352
"ipld-dag-pb": "^0.20.0",
@@ -65,7 +64,7 @@
6564
"multicodec": "^2.0.1",
6665
"multihashes": "^3.0.1",
6766
"nanoid": "^3.1.12",
68-
"node-fetch": "^2.6.0",
67+
"native-abort-controller": "~0.0.3",
6968
"parse-duration": "^0.4.4",
7069
"stream-to-it": "^0.2.2",
7170
"uint8arrays": "^1.1.0"
@@ -75,7 +74,7 @@
7574
"cross-env": "^7.0.0",
7675
"go-ipfs": "^0.7.0",
7776
"interface-ipfs-core": "^0.140.0",
78-
"ipfsd-ctl": "^7.0.0",
77+
"ipfsd-ctl": "^7.0.2",
7978
"it-all": "^1.0.4",
8079
"it-concat": "^1.0.1",
8180
"it-pipe": "^1.1.0",

src/add-all.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const configure = require('./lib/configure')
66
const multipartRequest = require('./lib/multipart-request')
77
const toUrlSearchParams = require('./lib/to-url-search-params')
88
const anySignal = require('any-signal')
9-
const AbortController = require('abort-controller').default
9+
const AbortController = require('native-abort-controller')
1010

1111
module.exports = configure((api) => {
1212
/**

src/block/put.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const multipartRequest = require('../lib/multipart-request')
77
const configure = require('../lib/configure')
88
const toUrlSearchParams = require('../lib/to-url-search-params')
99
const anySignal = require('any-signal')
10-
const AbortController = require('abort-controller').default
10+
const AbortController = require('native-abort-controller')
1111

1212
module.exports = configure(api => {
1313
/**

src/config/replace.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const multipartRequest = require('../lib/multipart-request')
55
const configure = require('../lib/configure')
66
const toUrlSearchParams = require('../lib/to-url-search-params')
77
const anySignal = require('any-signal')
8-
const AbortController = require('abort-controller').default
8+
const AbortController = require('native-abort-controller')
99

1010
module.exports = configure(api => {
1111
return async (config, options = {}) => {

src/dag/put.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const configure = require('../lib/configure')
99
const multipartRequest = require('../lib/multipart-request')
1010
const toUrlSearchParams = require('../lib/to-url-search-params')
1111
const anySignal = require('any-signal')
12-
const AbortController = require('abort-controller').default
12+
const AbortController = require('native-abort-controller')
1313
const multicodec = require('multicodec')
1414

1515
module.exports = configure((api, opts) => {

src/files/write.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const configure = require('../lib/configure')
66
const multipartRequest = require('../lib/multipart-request')
77
const toUrlSearchParams = require('../lib/to-url-search-params')
88
const anySignal = require('any-signal')
9-
const AbortController = require('abort-controller').default
9+
const AbortController = require('native-abort-controller')
1010

1111
module.exports = configure(api => {
1212
return async (path, input, options = {}) => {

src/lib/multipart-request.browser.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict'
22

3-
const normaliseInput = require('ipfs-core-utils/src/files/normalise-input')
3+
const normaliseInput = require('ipfs-core-utils/src/files/normalise-input/index.browser')
44
const modeToString = require('./mode-to-string')
55
const mtimeToObject = require('./mtime-to-object')
66
const { File, FormData } = require('ipfs-utils/src/globalthis')

src/lib/multipart-request.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ const modeToString = require('../lib/mode-to-string')
66
const mtimeToObject = require('../lib/mtime-to-object')
77
const merge = require('merge-options').bind({ ignoreUndefined: true })
88
const toStream = require('it-to-stream')
9+
const { isElectronRenderer } = require('ipfs-utils/src/env')
910

1011
async function multipartRequest (source = '', abortController, headers = {}, boundary = `-----------------------------${nanoid()}`) {
1112
async function * streamFiles (source) {
@@ -73,3 +74,7 @@ async function multipartRequest (source = '', abortController, headers = {}, bou
7374
}
7475

7576
module.exports = multipartRequest
77+
78+
if (isElectronRenderer) {
79+
module.exports = require('./multipart-request.browser')
80+
}

src/object/patch/append-data.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const multipartRequest = require('../../lib/multipart-request')
55
const configure = require('../../lib/configure')
66
const toUrlSearchParams = require('../../lib/to-url-search-params')
77
const anySignal = require('any-signal')
8-
const AbortController = require('abort-controller').default
8+
const AbortController = require('native-abort-controller')
99

1010
module.exports = configure(api => {
1111
return async (cid, data, options = {}) => {

src/object/patch/set-data.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const multipartRequest = require('../../lib/multipart-request')
55
const configure = require('../../lib/configure')
66
const toUrlSearchParams = require('../../lib/to-url-search-params')
77
const anySignal = require('any-signal')
8-
const AbortController = require('abort-controller').default
8+
const AbortController = require('native-abort-controller')
99

1010
module.exports = configure(api => {
1111
return async (cid, data, options = {}) => {

0 commit comments

Comments
 (0)