Fix: Ensure File Argument 'key' is Provided in kubo-rpc-client #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where the key argument for files is incorrectly required, resolving #144. The implementation follows the IPFS documentation to ensure correct handling.
Changes
Fixed the bug that caused the "file argument 'key' is required" error.
Adjusted the implementation to align with IPFS API expectations.
Successfully tested the fix via RPC calls.
Blockers
Encountered a conflict between the current type changes in the KuboRPCClient interface on the repo and the version published on npm, preventing unit test execution.
Despite this, manual testing through RPC confirmed the fix works as expected.