fix: more strict regex

lidel · lidel · commit 36b62c1f8ff3 · 2021-04-29T23:55:18.000+02:00
#8096 (comment)
diff --git a/repo/common/common.go b/repo/common/common.go
@@ -8,8 +8,8 @@ import (
 	"github.com/google/uuid"
 )
 
-// Find dynamic map key names passed  as Parent["foo"] notation
-var bracketsRe = regexp.MustCompile(`\[([^\[\]]*)\]`)
+// Find dynamic map key names passed with Parent["foo"] notation
+var bracketsRe = regexp.MustCompile(`\["([^\["\]]*)"\]`)
 
 // Normalization for supporting arbitrary dynamic keys with dots:
 // Gateway.PublicGateways["gw.example.com"].UseSubdomains

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,8 @@ import (`
`8`	`8`	`"github.com/google/uuid"`
`9`	`9`	`)`
`10`	`10`
`11`		`-// Find dynamic map key names passed as Parent["foo"] notation`
`12`		-var bracketsRe = regexp.MustCompile(`\[([^\[\]]*)\]`)
	`11`	`+// Find dynamic map key names passed with Parent["foo"] notation`
	`12`	+var bracketsRe = regexp.MustCompile(`\["([^\["\]]*)"\]`)
`13`	`13`
`14`	`14`	`// Normalization for supporting arbitrary dynamic keys with dots:`
`15`	`15`	`// Gateway.PublicGateways["gw.example.com"].UseSubdomains`