ipfs-http-client block api timeout option

[tabcat]

seems like ipfs-http-api block api timeout option isnt working.

• Version:
  ipfs-http-client@52.0.3

{
  version: '0.10.0',
  commit: '',
  repo: '11',
  system: 'amd64/linux',
  golang: 'go1.16.8'
}

Severity:

High - The main functionality of the application does not work, API breakage, repo format breakage, etc.

Description:

ipfs-http-client block api doesnt seem to have timeout option

Steps to reproduce the error:

start an ipfs daemon with http api

IPFS_HTTP = require('ipfs-http-client')
client = IPFS_HTTP.create()
client.dag.put({}, { timeout: -1 }) // timeout error (good)
client.block.put(new Uint8Array([]), { timeout: -1 }) // no timeout error/completes (bad)

[lidel]

@tabcat what is your intention behind using value of -1?
I suspect you use go-ipfs as backend, is that right?

[tabcat]

The -1 is just to make it result in a timeout error every time, 0 was ignored and iirc 1 didn't work consistently. I want to test that we are passing the timeout option, orbitdb/-orbit-db-io#29. yes go-ipfs

[lidel]

Ok, transfering this to go-ipfs repo, as it looks like the bug is there:

timeout in dag put

timeout seems to break dag/put response

$ echo lol > file
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/dag/put?input-codec=raw&store-codec=raw"
{"Cid":{"/":"bafkreifeerfkipo5ny7ptzslxahu52ks62bdfkqaru62tr4ohnrh4vtvza"}}
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/dag/put?input-codec=raw&store-codec=raw&timeout=0"
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/dag/put?input-codec=raw&store-codec=raw&timeout=1"
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/dag/put?input-codec=raw&store-codec=raw&timeout=-1"

passing timeout=<n> should either have some effect (return error) or not impact regular response.
Right now empty response is returned as HTTP/1.1 200 OK which is clearly a bug

timeout in block put

same problem – passing timeout break response:

$ echo lol > file
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/block/put"
{"Key":"QmZPPfip1WVGtg56Uh7rUifeyQwUubtqzLYVvpmvXqtbEP","Size":4}
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/block/put?timeout=1"
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/block/put?timeout=0"
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/block/put?timeout=-1"

Right now empty response is returned as HTTP/1.1 200 OK which is clearly a bug

[alvin-reyes]

In my case, timeout=0 returns a response

$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/dag/put?input-codec=raw&store-codec=raw&timeout=0"
{"Cid":{"/":"bafkreifeerfkipo5ny7ptzslxahu52ks62bdfkqaru62tr4ohnrh4vtvza"}}
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/dag/put?input-codec=raw&store-codec=raw&timeout=1"
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/dag/put?input-codec=raw&store-codec=raw&timeout=-1"

$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/block/put?timeout=0"
{"Key":"QmZPPfip1WVGtg56Uh7rUifeyQwUubtqzLYVvpmvXqtbEP","Size":4}
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/block/put?timeout=1"
$ curl -X POST -F file=@file "http://127.0.0.1:5001/api/v0/block/put?timeout=-1"

and I keep getting this error eveytime I run the command

2021-12-02T21:37:50.994-0500    ERROR   tcp-tpt go-tcp-transport@v0.4.0/tcp.go:52       failed to enable TCP keepalive  {"error": "set tcp4 10.0.0.101:4001->218.94.151.194:1672: setsockopt: invalid argument"}

[BigLep]

@lidel : is this a good candidate for @schomatis ?