fix: no implicit any, add missing types (#852)

Author: SgtPooki

package-lock.json

@@ -87,6 +87,8 @@
     "@babel/preset-typescript": "^7.27.1",
     "@playwright/test": "^1.53.2",
     "@types/react": "^19.1.6",
+    "@types/react-dom": "^19.1.9",
+    "@types/wait-on": "^5.3.4",
     "aegir": "^47.0.19",
     "concurrently": "^9.1.2",
     "cross-env": "^7.0.3",

package.json

@@ -95,6 +95,11 @@ export default defineConfig({
             'dom.serviceWorkers.enabled': false
           }
         },
+        /**
+         *
+         * @param {object} param0
+         * @param {import('@playwright/test').Page} param0.page
+         */
         beforeEach: async ({ page }) => {
           await page.addInitScript(() => {
             Object.defineProperty(navigator, 'serviceWorker', {

playwright.config.js

@@ -33,6 +33,9 @@ async function renderUi (): Promise<void> {
     console.warn('Failed to load CSS config, UI will render without styles:', err)
   }
   const container = document.getElementById('root')
+  if (container == null) {
+    throw new Error('No root container found')
+  }
 
   const root = ReactDOMClient.createRoot(container)
 

src/app.tsx

@@ -1,7 +1,14 @@
 import React from 'react'
-import type { ReactElement } from 'react'
 
-export default ({ handleSubmit, requestPath, setRequestPath }): ReactElement => (
+const Form: React.FC<{
+  handleSubmit(e: React.FormEvent<HTMLFormElement>): void
+  requestPath: string
+  setRequestPath(path: string): void
+}> = ({
+  handleSubmit,
+  requestPath,
+  setRequestPath
+}) => (
   <form id='add-file' onSubmit={handleSubmit}>
     <label htmlFor='inputContent' className='f5 ma0 pb2 teal fw4 db'>CID, Content Path, or URL</label>
     <input
@@ -15,3 +22,5 @@ export default ({ handleSubmit, requestPath, setRequestPath }): ReactElement =>
     />
   </form>
 )
+
+export default Form

src/components/Form.tsx

@@ -28,8 +28,14 @@ function FormatHelp (): ReactElement {
     </>
   )
 }
+interface ValidationMessageProps {
+  cidOrPeerIdOrDnslink?: IpfsUriParts['cidOrPeerIdOrDnslink'],
+  requestPath: string,
+  protocol?: IpfsUriParts['protocol'],
+  children: React.ReactNode
+}
 
-function ValidationMessage ({ cidOrPeerIdOrDnslink, requestPath, protocol, children }): ReactElement {
+const ValidationMessage: React.FC<ValidationMessageProps> = ({ cidOrPeerIdOrDnslink, requestPath, protocol, children }) => {
   let errorElement: ReactElement | null = null
   if (requestPath == null || requestPath === '') {
     errorElement = <span><big className='f3'>↑</big> Enter a valid IPFS/IPNS content path.</span>

src/components/input-validator.tsx

@@ -16,15 +16,14 @@ import { uiLogger } from '../lib/logger.js'
 import { findOriginIsolationRedirect } from '../lib/path-or-subdomain.js'
 import { isUnregisterRequest } from '../lib/unregister-request.js'
 import { registerServiceWorker } from '../service-worker-utils.js'
-import type { ReactElement } from 'react'
 
 const log = uiLogger.forComponent('service-worker-context')
 
 export const ServiceWorkerContext = createContext({
   isServiceWorkerRegistered: false
 })
 
-export const ServiceWorkerProvider = ({ children }): ReactElement => {
+export const ServiceWorkerProvider: React.FC<{ children: React.ReactNode }> = ({ children }) => {
   const [isServiceWorkerRegistered, setIsServiceWorkerRegistered] = useState(false)
 
   useEffect(() => {

src/context/service-worker-context.tsx

@@ -126,12 +126,12 @@ export async function getConfig (logger: ComponentLogger): Promise<ConfigDb> {
     let gateways = defaultGateways
     let routers = defaultRouters
     let dnsJsonResolvers = defaultDnsJsonResolvers
-    let enableRecursiveGateways
-    let enableWss
-    let enableWebTransport
-    let enableGatewayProviders
-    let fetchTimeout
-    let debug = ''
+    let enableRecursiveGateways = defaultEnableRecursiveGateways
+    let enableWss = defaultEnableWss
+    let enableWebTransport = defaultEnableWebTransport
+    let enableGatewayProviders = defaultEnableGatewayProviders
+    let fetchTimeout = defaultFetchTimeout * 1000
+    let debug = defaultDebug()
     let serviceWorkerRegistrationTTL = defaultServiceWorkerRegistrationTTL
     let _supportsSubdomains = defaultSupportsSubdomains
 
@@ -150,13 +150,13 @@ export async function getConfig (logger: ComponentLogger): Promise<ConfigDb> {
       routers = config.routers
 
       dnsJsonResolvers = config.dnsJsonResolvers
-      enableRecursiveGateways = config.enableRecursiveGateways ?? defaultEnableRecursiveGateways
-      enableWss = config.enableWss ?? defaultEnableWss
-      enableWebTransport = config.enableWebTransport ?? defaultEnableWebTransport
-      enableGatewayProviders = config.enableGatewayProviders ?? defaultEnableGatewayProviders
-      fetchTimeout = config.fetchTimeout ?? (defaultFetchTimeout * 1000)
-      _supportsSubdomains ??= config._supportsSubdomains
-      serviceWorkerRegistrationTTL = config.serviceWorkerRegistrationTTL ?? defaultServiceWorkerRegistrationTTL
+      enableRecursiveGateways = config.enableRecursiveGateways
+      enableWss = config.enableWss
+      enableWebTransport = config.enableWebTransport
+      enableGatewayProviders = config.enableGatewayProviders
+      fetchTimeout = config.fetchTimeout
+      _supportsSubdomains = config._supportsSubdomains
+      serviceWorkerRegistrationTTL = config.serviceWorkerRegistrationTTL
     } catch (err) {
       log('error loading config from db', err)
     } finally {
@@ -176,18 +176,18 @@ export async function getConfig (logger: ComponentLogger): Promise<ConfigDb> {
 
     // always return the config, even if we failed to load it.
     return {
-      gateways,
-      routers,
-      dnsJsonResolvers,
-      enableRecursiveGateways,
-      enableWss,
-      enableWebTransport,
-      enableGatewayProviders,
-      debug,
-      fetchTimeout,
-      serviceWorkerRegistrationTTL,
-      _supportsSubdomains
-    }
+      gateways: gateways ?? defaultGateways,
+      routers: routers ?? defaultRouters,
+      dnsJsonResolvers: dnsJsonResolvers ?? defaultDnsJsonResolvers,
+      enableRecursiveGateways: enableRecursiveGateways ?? defaultEnableRecursiveGateways,
+      enableWss: enableWss ?? defaultEnableWss,
+      enableWebTransport: enableWebTransport ?? defaultEnableWebTransport,
+      enableGatewayProviders: enableGatewayProviders ?? defaultEnableGatewayProviders,
+      debug: debug ?? defaultDebug(),
+      fetchTimeout: fetchTimeout ?? defaultFetchTimeout * 1000,
+      serviceWorkerRegistrationTTL: serviceWorkerRegistrationTTL ?? defaultServiceWorkerRegistrationTTL,
+      _supportsSubdomains: _supportsSubdomains ?? defaultSupportsSubdomains
+    } satisfies ConfigDb
   })().finally(() => {
     getConfigPromise = null
   })

src/lib/config-db.ts

@@ -20,6 +20,7 @@ import { createLibp2p } from 'libp2p'
 import * as libp2pInfo from 'libp2p/version'
 import { blake3 } from './blake3.js'
 import type { ConfigDb } from './config-db.js'
+import type { DelegatedRoutingV1HttpApiClient } from '@helia/delegated-routing-v1-http-api-client'
 import type { BlockBroker } from '@helia/interface'
 import type { VerifiedFetch } from '@helia/verified-fetch'
 import type { ComponentLogger } from '@libp2p/logger'
@@ -115,7 +116,10 @@ export async function libp2pDefaults (config: Libp2pDefaultsOptions): Promise<Li
     filterAddrs.push('tls') // /ip4/A.B.C.D/tcp/4002/tls/sni/example.com/http
   }
 
-  const libp2pOptions = {
+  interface Libp2pOptionsWithDelegatedRouting extends Libp2pOptions {
+    services: Libp2pOptions['services'] & Record<`delegatedRouter${number}`, () => DelegatedRoutingV1HttpApiClient>
+  }
+  const libp2pOptions: Libp2pOptionsWithDelegatedRouting = {
     privateKey,
     addresses: {}, // no need to listen on any addresses
     transports,
@@ -132,7 +136,7 @@ export async function libp2pDefaults (config: Libp2pDefaultsOptions): Promise<Li
       keychain: keychain(),
       ping: ping()
     }
-  } satisfies Libp2pOptions
+  } satisfies Libp2pOptionsWithDelegatedRouting
 
   // Add delegated routing services for each passed delegated router endpoint
   config.routers.forEach((router, i) => {

src/lib/get-verified-fetch.ts

@@ -11,7 +11,7 @@ export const convertDnsResolverObjectToInput = (dnsResolvers: Record<string, str
 }
 
 export const convertDnsResolverInputToObject = (dnsResolverInput: string): Record<string, string> => {
-  return dnsResolverInput.split('\n').map((u) => u.trim().split(' ')).reduce((acc, [key, url]) => {
+  return dnsResolverInput.split('\n').map((u) => u.trim().split(' ')).reduce<Record<string, string>>((acc, [key, url]) => {
     acc[key] = url
     return acc
   }, {})