Skip to content

Commit 55abf06

Browse files
authored
chore: run iso tests in CI (#915)
Run the isomorphic tests in CI and make release please require all testing jobs to have passed before it runs.
1 parent b39a55d commit 55abf06

File tree

2 files changed

+28
-2
lines changed

2 files changed

+28
-2
lines changed

.github/workflows/main.yml

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,21 @@ jobs:
3838
- run: npm run --if-present dep-check
3939
- run: npm run --if-present doc-check
4040

41+
test-iso:
42+
needs: build
43+
runs-on: ubuntu-latest
44+
steps:
45+
- uses: actions/checkout@v5
46+
- uses: actions/setup-node@v6
47+
with:
48+
node-version: lts/*
49+
- uses: ipfs/aegir/actions/cache-node-modules@main
50+
- run: npm run --if-present test:iso
51+
- uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5.5.1
52+
with:
53+
flags: iso
54+
files: .coverage/*,packages/*/.coverage/*
55+
4156
test-node:
4257
needs: build
4358
runs-on: ${{ matrix.os }}
@@ -232,7 +247,18 @@ jobs:
232247
release-please:
233248
runs-on: ubuntu-latest
234249
if: (github.event_name == 'workflow_dispatch' || github.event_name == 'push') && github.ref == 'refs/heads/main'
235-
needs: [ build, check ]
250+
needs: [
251+
check,
252+
test-iso,
253+
test-node,
254+
test-chrome,
255+
test-chrome-webworker,
256+
test-firefox,
257+
test-firefox-webworker,
258+
test-electron-main,
259+
test-electron-renderer,
260+
test-local-binary
261+
]
236262
permissions:
237263
contents: write # to create release
238264
pull-requests: write # to create release PR

src/lib/path-or-subdomain.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export const toSubdomainRequest = (location: Pick<Location, 'protocol' | 'host'
115115
}
116116
break
117117
default:
118-
throw new InvalidParametersError('Unknown namespace: "' + ns + '"')
118+
// ignore unknown namespaces
119119
}
120120

121121
const remainingPath = `/${segments.slice(2).join('/')}`

0 commit comments

Comments
 (0)