Skip to content

fix: abort signal listening #699

@SgtPooki

Description

@SgtPooki

When adding #689, I had to make a change to verified-fetch (ipfs/helia-verified-fetch#214) that uses abortable-iterator when we walk a path, but we should be handling this better..

This issue is for addressing whatever fix where-ever we need to (probably @helia/verified-fetch and maybe some underlying libraries) so that we can revert the 214 pull request to verified-fetch.

The abort signal is not being listened to somewhere but I couldn't reproduce (https://github.com/SgtPooki/repro-helia-libp2p-router-abort-handling) except inside the service worker gateway.

Hopefully ipfs/helia#774 with ipfs/helia#776 will fix this, but I installed all the latest packages (@next) in service worker and still was unable to see a correct 504 like we have after making the change in ipfs/helia-verified-fetch#214

cc @achingbrain

Repro steps in this project:

  1. install [email protected] and pin it
  2. Run configurable timeout value is respected test with npm run test:chrome -- -g 'configurable timeout value is respected'

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical: Tackled by core team ASAPbugSomething isn't workingeffort/daysEstimated to take multiple days, but less than a weekexp/wizardExtensive knowledge (implications, ramifications) requiredkind/bugA bug in existing code (including security flaws)need/analysisNeeds further analysis before proceedingneed/maintainers-inputNeeds input from the current maintainer(s)status/readyReady to be worked

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions