-
Notifications
You must be signed in to change notification settings - Fork 21
Description
When adding #689, I had to make a change to verified-fetch (ipfs/helia-verified-fetch#214) that uses abortable-iterator
when we walk a path, but we should be handling this better..
This issue is for addressing whatever fix where-ever we need to (probably @helia/verified-fetch
and maybe some underlying libraries) so that we can revert the 214 pull request to verified-fetch.
The abort signal is not being listened to somewhere but I couldn't reproduce (https://github.com/SgtPooki/repro-helia-libp2p-router-abort-handling) except inside the service worker gateway.
Hopefully ipfs/helia#774 with ipfs/helia#776 will fix this, but I installed all the latest packages (@next
) in service worker and still was unable to see a correct 504 like we have after making the change in ipfs/helia-verified-fetch#214
cc @achingbrain
Repro steps in this project:
- install [email protected] and pin it
- Run
configurable timeout value is respected
test withnpm run test:chrome -- -g 'configurable timeout value is respected'