Skip to content

Commit c37723d

Browse files
authored
chore: apply suggestions from code review
1 parent aefa3b7 commit c37723d

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

src/http-gateways/path-gateway.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,8 +682,6 @@ Gateway SHOULD return this header with error responses such as [`429 Too Many Re
682682
The "Retry-After" header indicates how long the user agent ought to wait before making a follow-up request. It uses the following syntax:
683683

684684
```
685-
Retry-After: <http-date>
686-
// or
687685
Retry-After: <delay-seconds>
688686
```
689687

src/http-gateways/trustless-gateway.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ A Client MUST confirm the record signature match `libp2p-key` from the requested
445445

446446
A Client MUST [perform additional record verification according to the IPNS specification](https://specs.ipfs.tech/ipns/ipns-record/#record-verification).
447447

448-
# Notes for implementers
448+
# Appendix: Notes for implementers
449449

450450
## Dedicated Probe Paths
451451

@@ -456,13 +456,13 @@ Trustless gateways SHOULD provide probing endpoints as described below.
456456
`bafkqaaa` is the identity empty CID. This endpoint can be used to probe that
457457
that the endpoint corresponds to a trustless gateway.
458458

459-
For block requests (`?format=raw`), when supported, it MUST return `200 OK`
459+
For block requests (signaled by `?format=raw` and `Accept: application/vnd.ipld.raw`), when supported, it MUST return `200 OK`
460460
and an empty body.
461461

462-
For CAR requests (`?format=car`), when supported, it MUST return `200 OK` and a valid CAR file with CAR Header `roots` set to `bafkqaaa`. Identity block MAY be skipped in the CAR Data section.
462+
For CAR requests (signaled by `?format=car` and `Accept: application/vnd.ipld.car`), when supported, it MUST return `200 OK` and a valid CAR file with CAR Header `roots` set to `bafkqaaa`. Identity block MAY be skipped in the CAR Data section.
463463

464464
This specific identity CID is special for probing. Other random
465-
identity CIDs SHOULD not be handled.
465+
identity CIDs MAY not be handled.
466466

467467
### `HEAD /ipfs/bafkqaaa`
468468

@@ -472,4 +472,4 @@ MUST support [`HEAD` requests](#head-ipfs-cid-path-params).
472472
It must return `200 OK` in all cases.
473473

474474
This specific identity CID is special for probing. Other random
475-
identity CIDs SHOULD not be handled.
475+
identity CIDs MAY not be handled.

0 commit comments

Comments
 (0)