Capitalizing and better naming

Author: shamirShahzad

lib/cmd_asn_bulk.go

@@ -80,7 +80,7 @@ func CmdASNBulk(f CmdASNBulkFlags, ii *ipinfo.Client, args []string, printHelp f
 	}
 
 	if ii.Token == "" {
-		return nil, errors.New("bulk lookups require a token; login via `ipinfo init`.")
+		return nil, errors.New("bulk lookups require a token; login via `ipinfo init`")
 	}
 
 	return ii.GetASNDetailsBatch(asns, ipinfo.BatchReqOpts{

lib/cmd_tool_aggregate.go

@@ -140,7 +140,7 @@ func CmdToolAggregate(
 		parsedIPs = append(parsedIPs, ips...)
 	}
 
-	adjacentCombined := combineAdjacent(stripOverlapping(iputil.List(parsedCIDRs)))
+	adjacentCombined := combineAdjacent(stripOverlapping(iputil.NewCidrList(parsedCIDRs)))
 
 	outlierIPs := make([]net.IP, 0)
 	length := len(adjacentCombined)

lib/iputil/cidr.go

@@ -14,7 +14,7 @@ type CIDR struct {
 	Network *net.IPNet
 }
 
-// newCidr creates a newCidr CIDR structure.
+// NewCidr creates a NewCidr CIDR structure.
 func NewCidr(s string) *CIDR {
 	ip, ipnet, err := net.ParseCIDR(s)
 	if err != nil {
@@ -47,8 +47,8 @@ func (c *CIDR) Size() int {
 	return int(math.Pow(2, float64(bits-ones)))
 }
 
-// list returns a slice of sorted CIDR structures.
-func List(s []string) []*CIDR {
+// NewCidrList returns a slice of sorted CIDR structures.
+func NewCidrList(s []string) []*CIDR {
 	out := make([]*CIDR, 0)
 	for _, c := range s {
 		out = append(out, NewCidr(c))

lib/iputil/regex.go

@@ -30,8 +30,8 @@ var V4SubnetRegex *regexp.Regexp
 var V6SubnetRegex *regexp.Regexp
 var SubnetRegex *regexp.Regexp
 
-const V4octet = `(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)`
-const IPv4RegexPattern = `(` + V4octet + `\.){3}` + V4octet
+const V4Octet = `(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)`
+const IPv4RegexPattern = `(` + V4Octet + `\.){3}` + V4Octet
 const IPv4RangeRegexPattern = IPv4RegexPattern + `[-,]` + IPv4RegexPattern
 const IPv4CIDRRegexPattern = IPv4RegexPattern + `\/([1-2]?[0-9]|3[0-2])`