fixing the return issues

Author: Samuel-Gill

ipinfo/handler.py

@@ -218,7 +218,7 @@ def getBatchDetails(
                 details = {}
                 details["ip"] = ip_address
                 details["bogon"] = True
-                return Details(details)
+                result[ip_address] = details
             else:
                 lookup_addresses.append(ip_address)
 
@@ -339,7 +339,7 @@ def getBatchDetailsIter(
                 details = {}
                 details["ip"] = ip_address
                 details["bogon"] = True
-                yield Details(details)
+                result[ip_address] = details
             else:
                 lookup_addresses.append(ip_address)
 
@@ -351,7 +351,7 @@ def getBatchDetailsIter(
 
         # all in cache - exit early.
         if len(lookup_addresses) == 0:
-            yield result.items()
+            raise StopIteration(result.items())
 
         url = API_URL + "/batch"
         headers = handler_utils.get_headers(self.access_token, self.headers)

tests/handler_test.py

@@ -196,5 +196,4 @@ def test_iterative_bogon_details():
     token = os.environ.get("IPINFO_TOKEN", "")
     handler = Handler(token)
     details = next(handler.getBatchDetailsIter(["127.0.0.1"]))
-    assert isinstance(details, Details)
-    assert details.all == {"bogon": True, "ip": "127.0.0.1"}
+    assert details == {"bogon": True, "ip": "127.0.0.1"}