cosmetic changes

Author: Samuel-Gill

ipinfo/handler.py

@@ -199,8 +199,12 @@ def getBatchDetails(
         result = {}
         lookup_addresses = []
 
-        # check if bogon.
+        # pre-populate with anything we've got in the cache, and keep around
+        # the IPs not in the cache.
         for ip_address in ip_addresses:
+            # if the supplied IP address uses the objects defined in the
+            # built-in module ipaddress extract the appropriate string notation
+            # before formatting the URL.
             if isinstance(ip_address, IPv4Address) or isinstance(
                 ip_address, IPv6Address
             ):
@@ -214,17 +218,6 @@ def getBatchDetails(
             else:
                 lookup_addresses.append(ip_address)
 
-        # pre-populate with anything we've got in the cache, and keep around
-        # the IPs not in the cache.
-        for ip_address in ip_addresses:
-            # if the supplied IP address uses the objects defined in the
-            # built-in module ipaddress extract the appropriate string notation
-            # before formatting the URL.
-            if isinstance(ip_address, IPv4Address) or isinstance(
-                ip_address, IPv6Address
-            ):
-                ip_address = ip_address.exploded
-
             try:
                 cached_ipaddr = self.cache[cache_key(ip_address)]
                 result[ip_address] = cached_ipaddr

tests/handler_async_test.py

@@ -162,9 +162,7 @@ def _check_iterative_batch_details(ip, details, token):
 @pytest.mark.asyncio
 async def test_get_iterative_batch_details(batch_size):
     handler, token, ips = _prepare_batch_test()
-    async for ips, details in handler.getBatchDetailsIter(
-        ips, batch_size
-    ):
+    async for ips, details in handler.getBatchDetailsIter(ips, batch_size):
         _check_iterative_batch_details(ips, details, token)
 
 

tests/handler_test.py

@@ -163,9 +163,7 @@ def test_get_batch_details_total_timeout(batch_size):
 @pytest.mark.parametrize("batch_size", [None, 1, 2, 3])
 def test_get_iterative_batch_details(batch_size):
     handler, token, ips = _prepare_batch_test()
-    details_iterator = handler.getBatchDetailsIter(
-        ips, batch_size=batch_size
-    )
+    details_iterator = handler.getBatchDetailsIter(ips, batch_size=batch_size)
     for details in details_iterator:
         _check_iterative_batch_details(details, token)