Error: Unsupported map representation "stringpairs"

[RangerMauve]

I was attempting to use the stringpairs representation for a schema, but got an error when trying to pass it to the create() function in typed.js.

Here's the schema I used:

type Example {String:String} representation stringpairs {
      entryDelim ","
      innerDelim " "
}

Did I do something wrong? It appears as though typed.js just doesn't support this functionality.

[rvagg]

well, it parses, thankfully!

but alas no, I obviously skipped this one as can't-be-bothered in my initial passes:

js-ipld-schema/lib/typed.js

Lines 307 to 314 in fae8a4c

	let representation = 'map'
	if (typeDef.map.representation !== undefined) {
	if ('listpairs' in typeDef.map.representation && typeof typeDef.map.representation.listpairs === 'object') {
	representation = 'listpairs'
	} else if (!('map' in typeDef.map.representation) || typeof typeDef.map.representation.map !== 'object') {
	throw new Error(`Unsupported map representation "${Object.keys(typeDef.map.representation).join(',')}"`)
	}
	}

but it would be useful, I know Eric uses this one a lot in the things he does and it's useful for representing all sorts of unixy things. Do you have a direct use for it now? It probably wouldn't be too hard to add, it'd just need some solid testing because of all the possible variations and the fixtures I wrote for stringpairs are pretty .. basic.

[RangerMauve]

I don't have a direct use for it at the moment, and don't see one any time soon. It just happened to be the first thing I tested from the representations since it looked cool. 😁

[RangerMauve]

So, no rush on implenting this if there's higher priority stuff, could just leave this open as a tracking issue.

If you have time, it would be useful to document which features are unsupported in the README however.