DASL Testing: Tier 1

[makew0rld]

Hello,

I work on DASL Testing, a project funded by IPFS to test dag-cbor libraries.

I'm filing this issue to report on "Tier 1" bugs we've discovered in serde_ipld_dagcbor. More information is available here.

Please feel free to use this issue for tracking bug fixes, asking me questions, or anything else that's helpful.

Bugs

• Maps with integer keys can be encoded
• Maps with integer keys are decoded without error (ex: hex a10000 becomes {"": 0})
• Big nums are encoded (ex: c249010000000000000000)
• Trying to encode tagged objects (that are not CIDs) will not raise an error
  • Ex: c07819323032352d30352d32365431363a31383a31372d30343a3030 (view)
  • I am decoding this with ciborium and holding it in a Value
  • Encoding output from serde_ipld_dagcbor: a16a4040544147474544404082007819323032352d30352d32365431363a31383a31372d30343a3030 (view)
  • Let me know if this bug is not relevant as I'm not that familiar with Rust

---

You can view all the tests in more detail on the DASL testing website: https://hyphacoop.github.io/dasl-testing/

[vmx]

Thanks for testing. It would be great if you could incorporate the tests into our main IPLD test fixtures repo at https://github.com/ipld/codec-fixtures. This way the implementations can easily run those test and fix the bugs accordingly

[makew0rld]

Thanks for the suggestion. I'll try and work on this, although I don't have a timeline for it right now.