refactor: address code smells (#304)

Author: JulienMessageIppon

service/analysisService.ts

@@ -36,12 +36,10 @@ class AnalysisService extends HttpFactory {
 
   async getAllAnalyses() {
     const analyses = await this.getCall<Analysis[]>(this.RESOURCE);
-    const analysesWithCO2Converted = analyses.map((analysis) => ({
+    return analyses.map((analysis) => ({
       ...analysis,
       co2Converted: convertEstimateToBestMassUnit(analysis.co2Gr),
     }));
-
-    return analysesWithCO2Converted;
   }
 
   async getAnalysisById(analysisId: string) {

service/awsDataCenterService.ts

@@ -43,10 +43,7 @@ class AWSDataCenterService extends HttpFactory {
     const infrastructure =
       await this.infrastructureService.getInfrastructure(infrastructureId);
     const regions = await this.getAllAWSDataCenter();
-    const currentRegion = regions.find(
-      (region) => region.id === infrastructure.defaultRegion,
-    );
-    return currentRegion;
+    return regions.find((region) => region.id === infrastructure.defaultRegion);
   }
 }
 

service/scanService.ts

@@ -22,11 +22,10 @@ class ScanService extends HttpFactory {
   private readonly RESOURCE = "/api/scanner";
   async getAllScans(): Promise<Scan[]> {
     const scans = await this.getCall<Scan[]>(this.RESOURCE);
-    const scansWithCO2Converted = scans.map((scan) => ({
+    return scans.map((scan) => ({
       ...scan,
       co2Converted: convertEstimateToBestMassUnit(scan.co2Gr),
     }));
-    return scansWithCO2Converted;
   }
 
   async getScanById(scanId: string): Promise<EstimatedScan> {