* Only provision peers if there are any

jbemmel · jbemmel · commit 24cdcf7edf7d · 2025-06-24T11:29:43.000-05:00
* Add iBGP confederation peer (TODO IGP)
diff --git a/netsim/extra/bgp.confederation/cumulus_nvue.j2 b/netsim/extra/bgp.confederation/cumulus_nvue.j2
@@ -6,4 +6,6 @@
            !
            router bgp {{ bgp.as }}
              bgp confederation identifier {{ bgp.confederation.as }}
+{% if bgp.confederation.peers %}
              bgp confederation peers {{ bgp.confederation.peers|join(' ') }}
+{% endif %}
diff --git a/netsim/extra/bgp.confederation/dellos10.j2 b/netsim/extra/bgp.confederation/dellos10.j2
@@ -1,4 +1,6 @@
 !
 router bgp {{ bgp.as }}
   confederation identifier {{ bgp.confederation.as }}
+{% if bgp.confederation.peers %}
   confederation peers {{ bgp.confederation.peers|join(' ') }}
+{% endif %}
diff --git a/netsim/extra/bgp.confederation/eos.j2 b/netsim/extra/bgp.confederation/eos.j2
@@ -1,4 +1,6 @@
 !
 router bgp {{ bgp.as }}
   bgp confederation identifier {{ bgp.confederation.as }}
+{% if bgp.confederation.peers %}
   bgp confederation peers {{ bgp.confederation.peers|join(' ') }}
+{% endif %}
diff --git a/netsim/extra/bgp.confederation/frr.j2 b/netsim/extra/bgp.confederation/frr.j2
@@ -1,4 +1,6 @@
 !
 router bgp {{ bgp.as }}
   bgp confederation identifier {{ bgp.confederation.as }}
+{% if bgp.confederation.peers %}
   bgp confederation peers {{ bgp.confederation.peers|join(' ') }}
+{% endif %}
diff --git a/tests/integration/bgp.confederation/01-baseline.yml b/tests/integration/bgp.confederation/01-baseline.yml
@@ -10,7 +10,7 @@ groups:
   _auto_create: True
 
   confed:
-    members: [ c1, c2 ]
+    members: [ c1, c2, c3 ]
 
   ext:
     members: [ e1 ]
@@ -24,10 +24,15 @@ nodes:
     bgp.as: 65002
     device: frr
     provider: clab
+  c3:
+    bgp.as: 65002 # Same as C2
+    device: frr
+    provider: clab
   e1:
     bgp.as: 65003
 
 links:
 - c1-c2
 - c1-e1
 - c2-e1
+- c2-c3 # iBGP within same confederation

Original file line number	Diff line number	Diff line change
`@@ -6,4 +6,6 @@`
`6`	`6`	`!`
`7`	`7`	`router bgp {{ bgp.as }}`
`8`	`8`	`bgp confederation identifier {{ bgp.confederation.as }}`
	`9`	`+{% if bgp.confederation.peers %}`
`9`	`10`	`bgp confederation peers {{ bgp.confederation.peers\|join(' ') }}`
	`11`	`+{% endif %}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,6 @@`
`1`	`1`	`!`
`2`	`2`	`router bgp {{ bgp.as }}`
`3`	`3`	`confederation identifier {{ bgp.confederation.as }}`
	`4`	`+{% if bgp.confederation.peers %}`
`4`	`5`	`confederation peers {{ bgp.confederation.peers\|join(' ') }}`
	`6`	`+{% endif %}`