Skip to content

Commit bcb73bf

Browse files
authored
Split CI/CD tests into separate on-push and on-pull workflows (#2494)
Parts of the CI/CD tests were repeated twice, once on "push" trigger, once on "pull_request" trigger. This commit splits the tests (thus removing duplication) and reduces the range of Python versions tested during the more expensive "pull_request" run as we haven't found a scenario yet where all transformation tests would pass but an integration test would fail only with an older Python version. Note: that might change when we start adding outputs to the integration tests.
1 parent 84e8aa3 commit bcb73bf

File tree

2 files changed

+30
-11
lines changed

2 files changed

+30
-11
lines changed

.github/workflows/t-pull.yml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
name: Check integration tests with "none" device
2+
3+
on:
4+
pull_request:
5+
paths:
6+
- '**.py'
7+
- '**.yml'
8+
9+
jobs:
10+
tests:
11+
runs-on: ubuntu-latest
12+
strategy:
13+
max-parallel: 6
14+
matrix:
15+
python-version: [ "3.11", "3.12", "3.13" ]
16+
steps:
17+
- uses: actions/checkout@v4
18+
- name: Set up Python ${{ matrix.python-version }}
19+
uses: actions/setup-python@v5
20+
with:
21+
python-version: ${{ matrix.python-version }}
22+
- name: Install dependencies
23+
run: |
24+
python -m pip install --upgrade pip
25+
pip install -r requirements.txt -r requirements-dev.txt
26+
- name: Check integration tests
27+
run: |
28+
cd tests
29+
./check-integration-tests.sh
Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Run CICD Tests
1+
name: Run mypy and data transformation tests
22

33
on:
44
push:
@@ -7,11 +7,6 @@ on:
77
- '**.py'
88
- '**.yml'
99

10-
pull_request:
11-
paths:
12-
- '**.py'
13-
- '**.yml'
14-
1510
jobs:
1611
tests:
1712
runs-on: ubuntu-latest
@@ -40,8 +35,3 @@ jobs:
4035
run: |
4136
cd tests
4237
PYTHONPATH="../" pytest
43-
- name: Check integration tests
44-
if: ${{ github.event_name == 'pull_request' }}
45-
run: |
46-
cd tests
47-
./check-integration-tests.sh

0 commit comments

Comments
 (0)