Put provider specific properties under <provider>.xxx scope

[jbemmel]

For example, on Containerlab we have provider_kind which gets copied to node.kind

Instead, each provider could declare attributes:

clab:
 attributes:
  node: [ kind, type ]
 devices: 
  srlinux:
   kind: srl
   type: ixrd2

and then those would be copied to node.<provider>.xxx:

clab:
 kind: srl
 type: ixrd2

and referenced in templates as {{ clab.kind }}, etc.

[ipspace]

Totally agree with you -- we need to restructure the current way of dealing with provider-specific settings. It would be best to move everything under devices.device, for example devices.srlinux.clab.

group_vars could go there as well as provider-specific node attributes which would then be specified in providers.p.attributes.node, for example:

providers.clab.attributes.node: [ kind,type ]

Provider-specific settings would then (according to your idea) go into node.provider dictionary, for example nodes.r1.clab.kind.

I missing something? If not I could whip this up pretty soon.

[ipspace]

Implemented a long time ago