Skip to content

Initial implementation of iol2 STP#2481

Merged
ipspace merged 8 commits intodevfrom
cisco_stp
Jul 6, 2025
Merged

Initial implementation of iol2 STP#2481
ipspace merged 8 commits intodevfrom
cisco_stp

Conversation

@DanPartelly
Copy link
Collaborator

Based on Arista.

It passes all netlab integration tests and was also validated on a lot of topologies from:

https://github.com/ipspace/netlab-examples/tree/master/STP/examples

Doesn't handle stub port types (does any template ???)

@DanPartelly DanPartelly requested review from ipspace and jbemmel July 3, 2025 16:42
Copy link
Collaborator

@jbemmel jbemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor structural changes suggested:

{% if (STP disabled) %}
no spanning-tree vlan 1-4094
{% else %}
# Rest of the template
{% endif %}

.. although I suppose in theory one could disable stp at the top level, and enable it for a particular vlan or interface.

Up to you if you think that should be supported

@DanPartelly
Copy link
Collaborator Author

We have in docs STP Docs in section Global, Node, Link, Interface, and VLAN Parameters a tip: You can set the ‌stp.enable parameter in the ‌vlans dictionary to enable per-VLAN STP.

So ... Anyways, Ill change it to your preferred version since you wrote the STP module and you know best what where your intentions behind some choices.

Dan Partelly added 2 commits July 4, 2025 18:03
@DanPartelly DanPartelly requested a review from jbemmel July 4, 2025 16:00
@DanPartelly
Copy link
Collaborator Author

DanPartelly commented Jul 4, 2025

Default pvrstp / pvstp to long pathcost method,

@DanPartelly DanPartelly requested a review from jbemmel July 4, 2025 17:24
ipspace added a commit that referenced this pull request Jul 5, 2025
Copy link
Owner

@ipspace ipspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (but then mercifully I know nothing about STP), and the integration tests pass.

@ipspace ipspace merged commit 460e665 into dev Jul 6, 2025
@ipspace ipspace deleted the cisco_stp branch July 6, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants