[BUG] JunOS inconsistency in routing policy and prefix lists

[ssasso]

JunOS routing templates is generating inconsistent prefix list names wrt usage in policy.

I think this has never been raised as error in integration tests because there the af top level host var always contains both ipv4 and ipv6.

Prefix lists are generated for all the topology address families (af var),

netlab/netsim/ansible/templates/routing/_prefix_list_junos.j2

Line 6 in 9aac9ca

{% for pf_af in af %}

while policy-statement blindly tries to always use both

netlab/netsim/ansible/templates/routing/_route_policy_junos.j2

Line 96 in 9aac9ca

{% for match_af in ['ipv4', 'ipv6'] %}

and this results in a configuration error in case only a single AF is enabled.

i.e.,

module_stderr: 'b''error: Policy error: ag_aggregate-ipv6 route-filter-list referenced (in term seq10_ipv6) but not defined\nerror: configuration check-out failed'''

[ssasso]

Additionally, same happens if additional families are enabled, i.e.

module_stderr: 'b''error: Policy error: ag_aggregate-vpnv4 route-filter-list referenced (in term seq10_vpnv4) but not defined\nerror: configuration check-out failed'''

[ipspace]

I think this has never been raised as error in integration tests because there the af top level host var always contains both ipv4 and ipv6.

So we need an IPv4-only integration test?

[ssasso]

So we need an IPv4-only integration test?

maybe we could try to see if - instead of creating a new one - we can convert one of the existing policy tests to be ipv4-only or ipv6-only

[ipspace]

I think this has never been raised as error in integration tests because there the af top level host var always contains both ipv4 and ipv6.

Prefix lists are generated for all the topology address families (af var),

Am I right that this only happens with prefix lists (and not other routing policies)? We only have a single integration test for prefix lists, and I would like to keep that one dual-stacked for obvious reasons.

Should we add prefix lists to some other test together with a plugin that would remove them if the device under test does not support them?