Skip to content

Commit 5ef1f4e

Browse files
authored
Merge pull request #219 from ipums/stabilize-xgboost
Remove notes about XGBoost being unstable
2 parents 9bd3a50 + d1ec989 commit 5ef1f4e

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,6 @@ After installing the dependencies for one or both of these algorithms, you can
7272
use them as model types in training and model exploration. You can read more
7373
about these models in the hlink documentation [here](https://hlink.docs.ipums.org/models.html).
7474

75-
*Note: The XGBoost-PySpark integration provided by the xgboost Python package is
76-
currently unstable. So the hlink xgboost support is experimental and may change
77-
in the future.*
78-
7975
## Docs
8076

8177
The documentation site can be found at [hlink.docs.ipums.org](https://hlink.docs.ipums.org).

hlink/linking/core/classifier.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ def choose_classifier(model_type: str, params: dict[str, Any], dep_var: str):
134134
elif model_type == "xgboost":
135135
if not _xgboost_available:
136136
raise ModuleNotFoundError(
137-
"To use the experimental 'xgboost' model type, you need to install "
137+
"To use the 'xgboost' model type, you need to install "
138138
"the xgboost library and its dependencies. Try installing hlink with "
139139
"the xgboost extra:\n\n pip install hlink[xgboost]"
140140
)

sphinx-docs/changelog.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ Hlink adheres to semantic versioning as much as possible.
2121
invoked by `select_column_mapping` when the configuration calls for them.
2222
[PR #207][pr207]
2323

24+
### Changed
25+
26+
* Stabilized the XGBoost feature, since the integration provided by the xgboost
27+
Python package is no longer unstable. [PR #219][pr219]
28+
2429
### Deprecated
2530

2631
* The `hlink.linking.core.transforms.apply_transform` function, which applies
@@ -422,6 +427,7 @@ and false negative data in model exploration. [PR #1][pr1]
422427
[pr207]: https://github.com/ipums/hlink/pull/207
423428
[pr212]: https://github.com/ipums/hlink/pull/212
424429
[pr213]: https://github.com/ipums/hlink/pull/213
430+
[pr219]: https://github.com/ipums/hlink/pull/219
425431

426432
[household-matching-docs]: config.html#household-matching
427433
[household-training-docs]: config.html#household-training-and-model-exploration

sphinx-docs/models.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,8 @@ maxBins = 6
121121

122122
XGBoost is an alternate, high-performance implementation of gradient boosting.
123123
It uses [xgboost.spark.SparkXGBClassifier](https://xgboost.readthedocs.io/en/stable/python/python_api.html#xgboost.spark.SparkXGBClassifier).
124-
Since the XGBoost-PySpark integration which the xgboost Python package provides
125-
is currently unstable, support for the xgboost model type is disabled in hlink
124+
Since the XGBoost-PySpark integration requires some additional Python packages,
125+
support for the xgboost model type is disabled in hlink
126126
by default. hlink will stop with an error if you try to use this model type
127127
without enabling support for it. To enable support for xgboost, install hlink
128128
with the `xgboost` extra.

0 commit comments

Comments
 (0)