Merge remote-tracking branch 'origin/master'

Author: Robert Kummer

README.md

@@ -120,7 +120,7 @@ For the new implemented way for json files we also support the `$useJson` flag.
 
 For registering artisan console command we provide the `ArtisanServiceProvider`.
 
-You have to fill the `$commands` array with your commands. If you provide a key this key will be the key for registration within the IoC container of laravel. The value should be the command class name like `SuperCommand::class` or a string e.g. `SuperCommand` which gets resolved to lookup a method `registerSuperCommand` within the service provider. So you can register more complex commands by using a separate method.
+You have to fill the `$commands` array with your commands. If you provide a key this key will be the key for registration within the IoC container of laravel. The value should be the command class name like `SuperCommand::class` or a string e.g. `SuperCommand` which gets resolved to lookup a method `registerSuperCommand` within the service provider (protected at least to get called). So you can register more complex commands by using a separate method.
 
 By default artisan commands will registered only on console runs. If you want to change that behaviour you can overwrite the value of `$registerOnlyForConsole` to make that happen.
 

src/Providers/Traits/PackagePath.php

@@ -4,19 +4,18 @@
 
 trait PackagePath
 {
-	/**
-	 * you have to set the package path to the absolute root path of your package like __DIR__ . '/../../' within
-	 * your Service Provider;
-	 *
-	 * @var string
-	 */
-	protected $packagePath = '';
+    /**
+     * you have to set the package path to the absolute root path of your package like __DIR__ . '/../../' within
+     * your Service Provider;
+     *
+     * @var string
+     */
+    protected $packagePath = '';
 
     /**
      * give relative path from package root and return absolute path
      *
      * @param string $relativePath
-     * @param string $dir
      *
      * @return string
      */
@@ -27,4 +26,4 @@ private function packagePath(string $relativePath): string
 
         return realpath($packagePath . DIRECTORY_SEPARATOR . $relativePath);
     }
-}
+}