Skip to content

Commit 109ff6c

Browse files
authored
Incorporate MR feedback
Fix an issue where exec_time variable could be undefined.
1 parent d5fe4cc commit 109ff6c

File tree

1 file changed

+4
-3
lines changed
  • src/jupyter_contrib_nbextensions/nbextensions/execute_time

1 file changed

+4
-3
lines changed

src/jupyter_contrib_nbextensions/nbextensions/execute_time/ExecuteTime.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,15 +264,16 @@ define([
264264
end_time = cell.metadata.ExecuteTime.end_time;
265265
var msg = options.template[end_time ? 'executed' : 'queued'];
266266
msg = msg.replace('${start_time}', format_moment(start_time));
267+
var show_timing = true;
267268
if (end_time) {
268269
end_time = moment(end_time);
269270
msg = msg.replace('${end_time}', format_moment(end_time));
270271
var exec_time = -start_time.diff(end_time);
271272
msg = msg.replace('${duration}', humanized_duration(exec_time));
273+
show_timing = exec_time >= options.hide_shorter_than_threshold_in_ms;
272274
}
273-
if (exec_time < options.hide_shorter_than_threshold_in_ms ) {
274-
toggle_timing_display([cell], false);
275-
}
275+
toggle_timing_display([cell], show_timing);
276+
276277
timing_area.text(msg);
277278
return timing_area;
278279
}

0 commit comments

Comments
 (0)