Skip to content

Commit 15ccd17

Browse files
authored
Merge pull request #1264 from rhilenova/master
Fixed collapsible_headings key conflict
2 parents 4883349 + 465ec3c commit 15ccd17

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ New features and bugfixes:
3434
- Add preprocessor to embed images into a notebook
3535
[#1067](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1067)
3636
[@juhasch](https://github.com/juhasch)
37+
- Fixed conflicts in collapsible_headings if keys are rebound.
38+
[@rhilenova](https://github.com/rhilenova)
3739

3840

3941
0.4.0

src/jupyter_contrib_nbextensions/nbextensions/collapsible_headings/main.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@
634634

635635
var kbm = Jupyter.keyboard_manager;
636636

637-
var action_up = kbm.actions.get(kbm.command_shortcuts.get_shortcut('up'));
637+
var action_up = kbm.actions.get("jupyter-notebook:select-previous-cell");
638638
var orig_up_handler = action_up.handler;
639639
action_up.handler = function (env) {
640640
for (var index = env.notebook.get_selected_index() - 1; (index !== null) && (index >= 0); index--) {
@@ -647,7 +647,7 @@
647647
return orig_up_handler.apply(this, arguments);
648648
};
649649

650-
var action_down = kbm.actions.get(kbm.command_shortcuts.get_shortcut('down'));
650+
var action_down = kbm.actions.get("jupyter-notebook:select-next-cell");
651651
var orig_down_handler = action_down.handler;
652652
action_down.handler = function (env) {
653653
var ncells = env.notebook.ncells();

0 commit comments

Comments
 (0)