Merge pull request #1181 from jcb91/scroll_down

[scroll_down] fix 5.x compatibility

Author: jcb91

src/jupyter_contrib_nbextensions/nbextensions/scroll_down/config.yaml

@@ -4,4 +4,9 @@ Description: Scroll outputs down automatically
 Link: readme.md
 Icon: icon.png
 Main: main.js
-Compatibility: 4.x
+Compatibility: 4.x, 5.x
+Parameters:
+- name: scrollDownIsEnabled
+  description: enable scroll_down toolbar button
+  input_type: checkbox
+  default: false

src/jupyter_contrib_nbextensions/nbextensions/scroll_down/main.js

@@ -23,8 +23,7 @@ define([
     }
 
     function setButtonColor() {
-        var bg = params.scrollDownIsEnabled ? "darkgray" : "";
-        $("#toggle_scroll_down").css("background-color",  bg);
+        $("#toggle_scroll_down").toggleClass('active', params.scrollDownIsEnabled);
     }
 
     function load_extension() {
@@ -34,16 +33,17 @@ define([
                 icon   : 'fa-angle-double-down ',
                 handler: toggleScrollDown
             }, 'toggle-auto-scroll-down', 'scroll_down')
-        ])).find('.btn').attr('id', 'toggle_runtools');
+        ])).find('.btn').attr('id', 'toggle_scroll_down');
 
         console.log("[ScrollDown] is loaded");
 
-        $(".output").on("resize", function () {
+        // the event was renamed from 'resize' to 'resizeOutput' in
+        // https://github.com/jupyter/notebook/commit/b4928d481abd9f7cd996fd4b24078a55880d21e6
+        $(".output").on("resize resizeOutput", function () {
             if (!params.scrollDownIsEnabled) return;
             var output = $(this);
             setTimeout(function () {
                 output.scrollTop(output.prop("scrollHeight"));
-                console.log("height: " + output.prop("scrollHeight"));
             }, 0);
         });
 

src/jupyter_contrib_nbextensions/nbextensions/scroll_down/readme.md

@@ -1,3 +1,13 @@
 # ScrollDown
 
-When enabled, scrolls cells' outputs down automatically.
+When enabled, this nbextension scrolls cells' outputs down automatically as
+they are enlarged. It can be enabled and disabled using the toolbar button:
+
+![](icon.png)
+
+
+Options
+-------
+
+The enabled status is toggleable with the toolbar button, which sets the option
+option `scrollDownIsEnabled` in the notebook config section.