Hide empty shape column

Incoperates changes form the code review
changed one C-style for to a modern forEach because it looks better and if
Array.some is supported then so is forEach

Author: Tadaboody

src/jupyter_contrib_nbextensions/nbextensions/varInspector/main.js

@@ -129,34 +129,29 @@ function html_table(jsonVars) {
     var kernel_config = cfg.kernels_config[kernelLanguage];
     var varList = JSON.parse(String(jsonVars))
 
-    var shape_str;
-    var has_shape = false;
-    if (varList.some(list_var => "varShape" in list_var )) { //if any of them have a shape
+    var shape_str = '';
+    if (varList.some(listVar => "varShape" in listVar && listVar.varShape !== '')) { //if any of them have a shape
         shape_str = '<th >Shape</th>';
-        has_shape = true;
     }
     var beg_table = '<div class=\"inspector\"><table class=\"table fixed table-condensed table-nonfluid \"><col /> \
  <col  /><col /><thead><tr><th >X</th><th >Name</th><th >Type</th><th >Size</th>' + shape_str + '<th >Value</th></tr></thead><tr><td> \
- </td></tr>'
-    var nb_vars = varList.length;
-    var shape_col_str;
-    for (var i = 0; i < nb_vars; i++) {
-        if (has_shape) {
-            shape_col_str = '</td><td>' + varList[i].varShape + '</td><td>';
-        } else {
-            shape_col_str = '';
+ </td></tr>';
+    varList.forEach(listVar => {
+        var shape_col_str = '';
+        if ('varShape' in listVar) {
+            shape_col_str = '</td><td>' + listVar.varShape + '</td><td>';
         }
-        beg_table = beg_table +
+        beg_table +=
             '<tr><td><a href=\"#\" onClick=\"Jupyter.notebook.kernel.execute(\'' +
-            kernel_config.delete_cmd_prefix + varList[i].varName + kernel_config.delete_cmd_postfix + '\'' + '); ' +
+            kernel_config.delete_cmd_prefix + listVar.varName + kernel_config.delete_cmd_postfix + '\'' + '); ' +
             'Jupyter.notebook.events.trigger(\'varRefresh\'); \">x</a></td>' +
-            '<td>' + _trunc(varList[i].varName, cfg.cols.lenName) + '</td><td>' + _trunc(varList[i].varType, cfg.cols.lenType) +
-            '</td><td>' + varList[i].varSize + shape_col_str + _trunc(varList[i].varContent, cfg.cols.lenVar) +
-            '</td></tr>'
+            '<td>' + _trunc(listVar.varName, cfg.cols.lenName) + '</td><td>' + _trunc(listVar.varType, cfg.cols.lenType) +
+            '</td><td>' + listVar.varSize + shape_col_str + _trunc(listVar.varContent, cfg.cols.lenVar) +
+            '</td></tr>';
+    });
+    var full_table = beg_table + '</table></div>';
+    return full_table;
     }
-    var full_table = beg_table + '</table></div>'
-    return full_table
-}
 
 
 

src/jupyter_contrib_nbextensions/nbextensions/varInspector/var_list.py

@@ -7,12 +7,10 @@
 _Jupyter = get_ipython()
 _nms.shell = _Jupyter.kernel.shell
 
-has_numpy = False
 try:
     import numpy as np
-    has_numpy = True
 except ImportError:
-    has_numpy = False
+    pass    
 
 def _getsizeof(x):
     # return the size of variable x. Amended version of sys.getsizeof
@@ -27,20 +25,16 @@ def _getsizeof(x):
 def _getshapeof(x):
     #returns the shape of x if it has one
     #returns None otherwise - might want to return an empty string for an empty collum
-    global has_numpy
-    if has_numpy:
-        try:
-            return x.shape
-        except AttributeError: #x does not have a shape
-            return None
+    try:
+        return x.shape
+    except AttributeError: #x does not have a shape
+        return None
 
 def var_dic_list():
     types_to_exclude = ['module', 'function', 'builtin_function_or_method',
                         'instance', '_Feature', 'type', 'ufunc']
     values = _nms.who_ls()
-    vardic = [{'varName': v, 'varType': type(eval(v)).__name__, 'varSize': str(_getsizeof(eval(v))), 'varContent': str(eval(v))[:200]}  # noqa
-    if has_numpy:
-        vardic['varSize'] = str(eval(_getshapeof(v)))
+    vardic = [{'varName': v, 'varType': type(eval(v)).__name__, 'varSize': str(_getsizeof(eval(v))), 'varShape': str(_getshapeof(eval(v))) if _getshapeof(eval(v)) else '', 'varContent': str(eval(v))[:200]}  # noqa
 
     for v in values if (v not in ['_html', '_nms', 'NamespaceMagics', '_Jupyter']) & (type(eval(v)).__name__ not in types_to_exclude)] # noqa 
     return json.dumps(vardic)